Skip to content

feat: add granularity and false_positive_rate options for indexes#6416

Merged
zhongzc merged 4 commits intomainfrom
zhongzc/bloom-filter-add-options
Jul 2, 2025
Merged

feat: add granularity and false_positive_rate options for indexes#6416
zhongzc merged 4 commits intomainfrom
zhongzc/bloom-filter-add-options

Conversation

@zhongzc
Copy link
Copy Markdown
Collaborator

@zhongzc zhongzc commented Jun 27, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Wait for GreptimeTeam/greptime-proto#249

What's changed and what's your intention?

Pass granularity and false_positive_rate from sql options to bloom_filter/creator.rs with necessary validation.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc force-pushed the zhongzc/bloom-filter-add-options branch from aea1513 to 5208d9a Compare June 27, 2025 11:01
@github-actions github-actions Bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Jun 27, 2025
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/datatypes/src/schema/column_schema.rs Outdated
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongzc added 2 commits July 2, 2025 07:04
@zhongzc zhongzc enabled auto-merge July 2, 2025 07:05
@zhongzc zhongzc added this pull request to the merge queue Jul 2, 2025
@evenyag evenyag added the backport This patch is to be backported to current release branch label Jul 2, 2025
Merged via the queue into main with commit 599f289 Jul 2, 2025
41 checks passed
@zhongzc zhongzc deleted the zhongzc/bloom-filter-add-options branch July 2, 2025 08:00
zhongzc added a commit that referenced this pull request Jul 2, 2025
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@evenyag evenyag mentioned this pull request Jul 2, 2025
18 tasks
zhongzc added a commit that referenced this pull request Jul 2, 2025
* feat: pick #6416 to release/0.15

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* upgrade proto

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

---------

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@evenyag evenyag removed the backport This patch is to be backported to current release branch label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants