feat: Procedure to create table and register table to catalog#1040
Merged
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom Feb 27, 2023
Merged
feat: Procedure to create table and register table to catalog#1040v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
v0y4g3r merged 12 commits intoGreptimeTeam:developfrom
Conversation
This was referenced Feb 20, 2023
evenyag
force-pushed
the
feat/procedure-create
branch
2 times, most recently
from
901bff8 to
32353a3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1040 +/- ##
===========================================
- Coverage 85.47% 85.31% -0.17%
===========================================
Files 455 458 +3
Lines 66285 66684 +399
===========================================
+ Hits 56659 56889 +230
- Misses 9626 9795 +169 |
evenyag
force-pushed
the
feat/procedure-create
branch
from
233fa1e to
05631a2
Compare
v0y4g3r
reviewed
Feb 23, 2023
evenyag
force-pushed
the
feat/procedure-create
branch
from
05631a2 to
371ec34
Compare
MichaelScofield
approved these changes
Feb 24, 2023
CreateTableProcedure just return error if the subprocedure is failed
evenyag
force-pushed
the
feat/procedure-create
branch
from
371ec34 to
f83b848
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…meTeam#1040) * feat: Add table-procedures crate * feat: Implement procedure to create table * feat: Integrate procedure manager to datanode * test: Test CreateTableProcedure * refactor: Rename table-procedures to table-procedure * feat: Implement create_table_by_procedure * chore: Remove comment * chore: Add todo * feat: Add procedure config to standalone mode * feat: Register table-procedure loaders * feat: Address review comments CreateTableProcedure just return error if the subprocedure is failed * chore: Address CR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR
CreateTableProcedureto create a table and register the table to catalog.table-procedurefor table-related procedures.Configuration section example:
Checklist
Refer to a related PR or issue link (optional)