feat(procedure): Add procedure watcher#1043
Merged
killme2008 merged 5 commits intoGreptimeTeam:developfrom Feb 21, 2023
Merged
Conversation
37 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1043 +/- ##
===========================================
- Coverage 85.79% 85.67% -0.12%
===========================================
Files 446 446
Lines 64848 64907 +59
===========================================
- Hits 55635 55612 -23
- Misses 9213 9295 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evenyag
requested review from
MichaelScofield,
killme2008,
v0y4g3r and
waynexia
evenyag
force-pushed
the
feat/procedure-watch
branch
from
073cf3d to
b32953b
Compare
2 tasks
MichaelScofield
approved these changes
Feb 21, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: Use watch channel to store ProcedureState * feat: Add a watcher to wait for state change * test: test watcher on procedure failure * feat: Only clear message cache on success * feat: submit returns Watcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add a
Watcherto watch the procedure state. Callers can use this watcher to wait until the procedure is done.Also refactor the runner. Now it uses RAII style to ensure the lock is released and the procedure is clean up.
Checklist
Refer to a related PR or issue link (optional)