feat: Add an error variant RetryLater#1058
Merged
v0y4g3r merged 11 commits intoGreptimeTeam:developfrom Feb 27, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1058 +/- ##
===========================================
- Coverage 85.43% 85.32% -0.12%
===========================================
Files 458 458
Lines 66684 66731 +47
===========================================
- Hits 56972 56937 -35
- Misses 9712 9794 +82 |
evenyag
reviewed
Feb 24, 2023
37 tasks
Contributor
Author
|
@evenyag PTAL :D |
Contributor
|
I added a new error Could you also refactor the |
evenyag
reviewed
Feb 27, 2023
Contributor
Author
Good idea! I have solved all the above code reviews.:D |
evenyag
reviewed
Feb 27, 2023
2 tasks
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: support retry error * fix: ci * fix: ci * fix: fmt * feat: add convert procedure error * Docs : add rustdoc * fix: cr * fix: cr * fix: rm unless code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add an error variant RetryLater for recoverable failure. (The default variant External always abort the procedure.)
Checklist
Refer to a related PR or issue link (optional)
#286
TODO
In order to better manage the retry logic, we will increase the maximum number of retries and increase the waiting time exponentially