feat(procedure): Max retry time#1095
Merged
killme2008 merged 40 commits intoGreptimeTeam:developfrom Mar 15, 2023
Merged
Conversation
jun0315
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1095 +/- ##
===========================================
- Coverage 85.20% 85.09% -0.12%
===========================================
Files 485 485
Lines 71588 71701 +113
===========================================
+ Hits 61000 61012 +12
- Misses 10588 10689 +101 |
evenyag
reviewed
Mar 1, 2023
37 tasks
Contributor
Author
|
I have solved all the above code reviews, PTAL :D @evenyag |
evenyag
reviewed
Mar 2, 2023
Contributor
Author
|
I have solved all the above code reviews, PTAL~ @evenyag |
evenyag
reviewed
Mar 6, 2023
Contributor
|
There are some conflicts. Could you please resolve them? @jun0315 |
Member
|
@jun0315 Any update? Looks like only some minor comments and conflicts waiting to be fixed. |
Contributor
Author
|
Sorry, I was a little busy the other day. I have fixed the above problem.:D @killme2008 @evenyag |
killme2008
reviewed
Mar 15, 2023
evenyag
reviewed
Mar 15, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: procedure config * fix: modify config * feat: add retry logic * feat: add error * feat: add it * feat: add it * feat: add it * feat: rm retry from runner * feat: use backon * feat: add retry_interval * feat: add retry_interval * fix: conflict * fix: cr * feat: add retry error and id * feat: rename * refactor: execute * feat: use config dir * fix: cr * fix: cr * fix: fmt * fix: fmt * fix: pr * fix: it * fix: rm unless cmd params * feat: add toml * fix: ut * feat: add rolling back * fix: cr * fix: cr * fix: cr * fix: ci * fix: ci * fix: ci * chore: Apply suggestions from code review --------- Co-authored-by: Yingwen <realevenyag@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Increase the maximum number of retries to avoid continuous retries.
Checklist
Refer to a related PR or issue link (optional)
#286
#1058