feat: print build output if it's failed in sqlness#2152
Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom Aug 11, 2023
Merged
feat: print build output if it's failed in sqlness#2152waynexia merged 2 commits intoGreptimeTeam:developfrom
waynexia merged 2 commits intoGreptimeTeam:developfrom
Conversation
waynexia
reviewed
Aug 11, 2023
2 tasks
NiwakaDev
approved these changes
Aug 11, 2023
Collaborator
NiwakaDev
left a comment
NiwakaDev
left a comment
There was a problem hiding this comment.
Thank you!! Looks good to me.
waynexia
approved these changes
Aug 11, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2152 +/- ##
===========================================
- Coverage 84.88% 84.54% -0.35%
===========================================
Files 694 694
Lines 109966 109966
===========================================
- Hits 93344 92968 -376
- Misses 16622 16998 +376 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: print build output if it's failed in sqlness * feat: print build output if it's failed in sqlness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
as title
Checklist
Refer to a related PR or issue link (optional)