feat: handle multiple grpc deletes#2150
Merged
MichaelScofield merged 5 commits intoGreptimeTeam:developfrom Aug 15, 2023
Merged
feat: handle multiple grpc deletes#2150MichaelScofield merged 5 commits intoGreptimeTeam:developfrom
MichaelScofield merged 5 commits intoGreptimeTeam:developfrom
Conversation
2 tasks
NiwakaDev
force-pushed
the
feat/handle_multiple_delete_request
branch
from
235b216 to
caadc69
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2150 +/- ##
===========================================
- Coverage 84.58% 84.27% -0.32%
===========================================
Files 698 699 +1
Lines 111745 112006 +261
===========================================
- Hits 94519 94389 -130
- Misses 17226 17617 +391 |
Collaborator
Author
|
It seems like |
Collaborator
|
@NiwakaDev I've made the cargo build in sqlness prints the output if it fails in #2152 . After that PR is merged, plz rebase your code and see how the ci fails |
NiwakaDev
force-pushed
the
feat/handle_multiple_delete_request
branch
2 times, most recently
from
4409ce8 to
2b0dcfe
Compare
Collaborator
|
@NiwakaDev disk is full. plz wait for #2158 |
NiwakaDev
force-pushed
the
feat/handle_multiple_delete_request
branch
3 times, most recently
from
9e9c40a to
ef8193e
Compare
killme2008
approved these changes
Aug 14, 2023
NiwakaDev
force-pushed
the
feat/handle_multiple_delete_request
branch
from
2c90952 to
490cb51
Compare
Collaborator
MichaelScofield
left a comment
MichaelScofield
left a comment
There was a problem hiding this comment.
LGTM. Please resolve the conflicts so I can merge it.
NiwakaDev
force-pushed
the
feat/handle_multiple_delete_request
branch
from
490cb51 to
79d41df
Compare
Collaborator
Author
I resolved them. |
MichaelScofield
approved these changes
Aug 15, 2023
Collaborator
|
@NiwakaDev thx! |
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Aug 16, 2023
* feat: handle multiple grpc deletes (GreptimeTeam#2150) * feat: handle multiple grpc deletes * fix: make DistDeleter::grpc_delete return usize * fix: remove backtrace from MissingTimeIndexColumn * fix: avoid using unwrap in PartitionRuleManager::split_delete_request * fix: simplify MissingTimeIndexColumn * refactor: improve the image building performance (GreptimeTeam#2175) * refactor: use '--output type=local' in 'build-greptime-by-buildx' target to reduce unnecessary 'docker cp'" Signed-off-by: zyy17 <zyylsxm@gmail.com> * refactor: improve the image building performance * ci: release centos dev builder * ci: use 'make build-by-dev-builder' to improve docker build performance * refactor: add 'which' command in centos * fix: add 'OUTPUT_DIR' to fix 'make docker-image-buildx' error * fix: fix incorrect dockerfile path Signed-off-by: zyy17 <zyylsxm@gmail.com> * refactor: remove configure-aws-credentials action and use env variables Signed-off-by: zyy17 <zyylsxm@gmail.com> * ci: update slack notification prompt * refactor: clean up the target directory before building artifacts of centos7 --------- Signed-off-by: zyy17 <zyylsxm@gmail.com> * docs: rfc of update metadata in single txn (GreptimeTeam#2165) * docs: rfc of update metadata in single txn * chore: apply suggestion from CR * feat: grpc handler result (GreptimeTeam#2107) * feat: grpc handler inner result * feat: ext header, x-greptime-err-code, x-greptime-err-msg * fix: sqlness case * chore: by comment * fix: convert status to Error * chore: minor `auth` crate change (GreptimeTeam#2176) * chore: pub auth_mysql * chore: pub all error * chore: remove back to error * chore: wrap failed permission check result to err * chore: minor change * feat: don't enable telemetry for debug building (GreptimeTeam#2177) --------- Signed-off-by: zyy17 <zyylsxm@gmail.com> Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com> Co-authored-by: zyy17 <zyylsxm@gmail.com> Co-authored-by: Weny Xu <wenymedia@gmail.com> Co-authored-by: JeremyHi <jiachun_feng@proton.me> Co-authored-by: shuiyisong <113876041+shuiyisong@users.noreply.github.com> Co-authored-by: dennis zhuang <killme2008@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: handle multiple grpc deletes * fix: make DistDeleter::grpc_delete return usize * fix: remove backtrace from MissingTimeIndexColumn * fix: avoid using unwrap in PartitionRuleManager::split_delete_request * fix: simplify MissingTimeIndexColumn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR allows
greptimedbto handle multiple grpc deletes.Checklist
Refer to a related PR or issue link (optional)
close #1708