feat(puffin): add file writer#2776
Merged
zhongzc merged 10 commits intoGreptimeTeam:developfrom Nov 21, 2023
Merged
Conversation
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
7 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2776 +/- ##
===========================================
- Coverage 84.36% 84.15% -0.21%
===========================================
Files 726 728 +2
Lines 113234 113522 +288
===========================================
+ Hits 95527 95537 +10
- Misses 17707 17985 +278 |
killme2008
reviewed
Nov 20, 2023
killme2008
reviewed
Nov 20, 2023
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
evenyag
reviewed
Nov 20, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
killme2008
reviewed
Nov 21, 2023
evenyag
approved these changes
Nov 21, 2023
Contributor
evenyag
left a comment
evenyag
left a comment
There was a problem hiding this comment.
Rest LGTM. You can merge the latest develop branch to pass the codecov check.
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add writer for Puffin in sync and async manner.
Mainly introduce
PuffinSyncWriterandPuffinAsyncWritertraits and implementations.Please note that
src/puffin/src/tests.rsis not a bin file, check it by clicking View File.Checklist
Refer to a related PR or issue link (optional)
#2705