Skip to content

feat(puffin): add file writer #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongzc merged 10 commits into from
Nov 21, 2023
Merged

feat(puffin): add file writer #2776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8b1b918
feat(puffin): add file writer
zhongzc Nov 20, 2023
831290c
Update src/puffin/src/file_format/writer/file.rs
zhongzc Nov 20, 2023
ba73e11
Update src/puffin/src/file_format/writer/file.rs
zhongzc Nov 20, 2023
0ab1fe0
feat: footer bytes with capacity
zhongzc Nov 20, 2023
e58859f
feat: footer bytes with capacity
zhongzc Nov 20, 2023
a2a2f44
Update src/puffin/src/file_format/writer.rs
zhongzc Nov 20, 2023
7c89849
feat: add flush
zhongzc Nov 20, 2023
b39f0ff
chore: specify default flags
zhongzc Nov 21, 2023
cbf2799
feat: close async writer
zhongzc Nov 21, 2023
daa8b46
Merge remote-tracking branch 'origin/develop' into zhongzc/puffin-for…
zhongzc Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/puffin/src/file_format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ pub const MIN_FOOTER_SIZE: u64 = MAGIC_SIZE * 2 + FLAGS_SIZE + PAYLOAD_SIZE_SIZE
bitflags! {
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
pub struct Flags: u32 {
const DEFAULT = 0b00000000;
Comment thread
zhongzc marked this conversation as resolved.

const FOOTER_PAYLOAD_COMPRESSED_LZ4 = 0b00000001;
}
}
4 changes: 2 additions & 2 deletions src/puffin/src/file_format/writer/footer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use snafu::ResultExt;

use crate::blob_metadata::BlobMetadata;
use crate::error::{Result, SerializeJsonSnafu};
use crate::file_format::{MAGIC, MIN_FOOTER_SIZE};
use crate::file_format::{Flags, MAGIC, MIN_FOOTER_SIZE};
use crate::file_metadata::FileMetadataBuilder;

/// Writer for the footer of a Puffin file.
Expand Down Expand Up @@ -73,7 +73,7 @@ impl FooterWriter {
///
/// TODO(zhongzc): support compression
Comment thread
killme2008 marked this conversation as resolved.
fn write_flags(&self, buf: &mut Vec<u8>) {
buf.extend_from_slice(&[0; 4]);
buf.extend_from_slice(&Flags::DEFAULT.bits().to_le_bytes());
}

fn footer_payload(&mut self) -> Result<Vec<u8>> {
Expand Down