feat(inverted_index.create): add external sorter#2950
Merged
zhongzc merged 27 commits intoGreptimeTeam:developfrom Dec 19, 2023
Merged
feat(inverted_index.create): add external sorter#2950zhongzc merged 27 commits intoGreptimeTeam:developfrom
zhongzc merged 27 commits intoGreptimeTeam:developfrom
Conversation
… files Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
…ls to poll Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
…ndex-create-sorter
7 tasks
evenyag
reviewed
Dec 18, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2950 +/- ##
===========================================
- Coverage 85.77% 85.27% -0.50%
===========================================
Files 758 762 +4
Lines 122730 123123 +393
===========================================
- Hits 105267 104995 -272
- Misses 17463 18128 +665 |
evenyag
reviewed
Dec 19, 2023
evenyag
approved these changes
Dec 19, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
killme2008
approved these changes
Dec 19, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
6c87118 to
6cd5cea
Compare
…ndex-create-sorter
Member
|
@zhongzc There is a clippy warning. |
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Collaborator
Author
Due to the toolchain update of the develop branch, fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Sortertrait for handling sorting of incremental input.ExternalSorterimplementation, together with the dependencyExternalTempFileProviderto enable access to external files. TheExternalSorterwill employ external sorting, has a parametermemory_usage_threshold, and tracks memory usage to ensure that the sorting is completed with a minimal memory footprint.Checklist
Refer to a related PR or issue link (optional)
#2705
next PR to be proposed:
feat(inverted_index.create): add index creator