feat(inverted_index.create): add index creator#4
Closed
zhongzc wants to merge 9 commits intozhongzc/inverted-index-create-sorterfrom
Closed
feat(inverted_index.create): add index creator#4zhongzc wants to merge 9 commits intozhongzc/inverted-index-create-sorterfrom
zhongzc wants to merge 9 commits intozhongzc/inverted-index-create-sorterfrom
Conversation
2 tasks
zhongzc
force-pushed
the
zhongzc/inverted-index-create-sorter
branch
from
b150ee4 to
58372b2
Compare
zhongzc
force-pushed
the
zhongzc/inverted-index-create-creator
branch
6 times, most recently
from
5eab396 to
963f54b
Compare
zhongzc
force-pushed
the
zhongzc/inverted-index-create-sorter
branch
from
63cb5bd to
3bc75de
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
This reverts commit 63cb5bd.
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
zhongzc
force-pushed
the
zhongzc/inverted-index-create-creator
branch
from
b071757 to
63ab226
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
2 tasks
* feat(inverted_index.create): add read/write for external intermediate files Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: MAGIC_CODEC_V1 -> CODEC_V1_MAGIC Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: polish comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: fix typos intermedia -> intermediate Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix: typos Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat(inverted_index.create): add external sorter Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: fix typos intermedia -> intermediate Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: polish comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: polish comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: drop the stream as early as possible to avoid recursive calls to poll Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: project merge sorted stream Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: add total_row_count to SortOutput Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: remove change of format Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: rename segment null bitmap Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: test type alias Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: allow `memory_usage_threshold` to be None to turn off dumping Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: change segment_row_count type to NonZeroUsize Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: accept BytesRef instead Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * feat: add `push_n` to adapt mito2 Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: add k-way merge TODO Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: more sorter cases Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * refactor: make the merge tree balance Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * Update src/index/src/inverted_index/create/sort/external_sort.rs Co-authored-by: Yingwen <realevenyag@gmail.com> * chore: address comments Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * chore: stable feature Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> Co-authored-by: Yingwen <realevenyag@gmail.com>
…ndex-create-creator
zhongzc
force-pushed
the
zhongzc/inverted-index-create-creator
branch
from
08988ff to
7391686
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
zhongzc
pushed a commit
that referenced
this pull request
Jan 16, 2025
* refactor: refactor PgStore * fix: election use bytea and txn use Serializable to avoid read unrepeatable (#4) * fix: election use bytea as well * fix: use Serializable to avoid read unrepeatable * chore: remove unused error * ci: enable pg kvbackend and sqlness * ci: switch on pg_kvbackend feature * fix: fix sqlness runner * chore: add pg_kvbackend feature gate * build(ci): add feature gate * fix: add retry for `PgStore` txn * fix: correct `SET_IDLE_SESSION_TIMEOUT` --------- Co-authored-by: Yohan Wal <1035325592@qq.com> Co-authored-by: CookiePieWw <profsyb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
IndexCreatortrait to handle the creation of indexes for multiple columns with multiple rows.SortIndexCreatorimplementation, which internally maintains the sorting of multiple columns, and relies on theInvertedIndexWriterto ultimately complete the construction of the index.Checklist
Refer to a related PR or issue link (optional)