feat(mito): Implement file cache#3022
Merged
Merged
Conversation
22 tasks
c0f2185 to
e7d235d
Compare
25c5c25 to
f04b7bb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 85.54% 85.05% -0.49%
==========================================
Files 793 794 +1
Lines 128447 128743 +296
==========================================
- Hits 109880 109508 -372
- Misses 18567 19235 +668 |
zhongzc
reviewed
Dec 28, 2023
zhongzc
approved these changes
Dec 29, 2023
Collaborator
zhongzc
left a comment
There was a problem hiding this comment.
I'm a little confused about the responsibilities. Cache is not responsible for storing files but deleting files, but it's not a big problem. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a cache for files in the
WriteCache. The design is similar to theReadCache.The differences are
This cache has the following features:
{region_id}.{file_id}as cache key and cached file nameChecklist
Refer to a related PR or issue link (optional)