Skip to content

feat(mito): Implement file cache #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
killme2008 merged 8 commits into from
Jan 3, 2024
Merged

feat(mito): Implement file cache #3022

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29cdb5a
feat: recover cache
evenyag Dec 27, 2023
36aac41
feat: moka features
evenyag Dec 27, 2023
9176b1e
test: tests for file cache
evenyag Dec 27, 2023
08c3fb2
chore: suppress warninig
evenyag Dec 28, 2023
f04b7bb
fix: parse_inde_key consider suffix
evenyag Dec 28, 2023
df87709
feat: update cache
evenyag Dec 28, 2023
1408487
feat: expose cache file path
evenyag Dec 28, 2023
2ae9523
feat: use cache_path in test
evenyag Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mito2/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ humantime-serde.workspace = true
lazy_static = "1.4"
log-store = { workspace = true, optional = true }
memcomparable = "0.2"
moka = { workspace = true, features = ["sync"] }
moka = { workspace = true, features = ["sync", "future"] }
num_cpus = "1.13"
object-store.workspace = true
parquet = { workspace = true, features = ["async"] }
Expand Down
5 changes: 5 additions & 0 deletions src/mito2/src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
//! Cache for the engine.

mod cache_size;
// TODO(yingwen): Remove this after the write cache is ready.
#[allow(unused)]
pub(crate) mod file_cache;
#[cfg(test)]
pub(crate) mod test_util;

Expand All @@ -38,6 +41,8 @@ const SST_META_TYPE: &str = "sst_meta";
const VECTOR_TYPE: &str = "vector";
// Metrics type key for pages.
const PAGE_TYPE: &str = "page";
// Metrics type key for files on the local store.
const FILE_TYPE: &str = "file";

/// Manages cached data for the engine.
pub struct CacheManager {
Expand Down
Loading