feat(inverted_index): Add applier builder to convert Expr to Predicates (Part 1)#3034
Merged
killme2008 merged 7 commits intoGreptimeTeam:mainfrom Dec 30, 2023
Conversation
… to Predicates (Part 1) Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
7 tasks
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3034 +/- ##
==========================================
- Coverage 85.54% 84.91% -0.64%
==========================================
Files 793 799 +6
Lines 128447 129030 +583
==========================================
- Hits 109880 109565 -315
- Misses 18567 19465 +898 |
evenyag
reviewed
Dec 29, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
evenyag
approved these changes
Dec 29, 2023
Co-authored-by: Yingwen <realevenyag@gmail.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR accomplishes the following:
Primarily, adds preliminary inverted index integration code to the
mito2crate, currently dealing with the read aspect.Introduces
SstIndexApplier, which will be embedded inParquetReaderBuilderin the future to offer indexing application services.Introduces
SstIndexApplierBuilder, which, as implied by its name, is responsible for constructingSstIndexApplier. It does a significant amount of work internally to recognize and transformExprintoPredicates understandable by the index crate.Given the substantial amount of code for the transformation, I plan to submit it in two separate PRs:
Betweenexpression as one of the examples.And,Or,Eq,Lt,LtEq,Gt,GtEq,RegexMatch,InList.Upgrade
regex-automata:^,$.Checklist
Refer to a related PR or issue link (optional)
#2705