Skip to content

feat(inverted_index): Add applier builder to convert Expr to Predicates (Part 2)#3068

Merged
zhongzc merged 9 commits intoGreptimeTeam:mainfrom
zhongzc:zhongzc/inverted-index-integration-applier-builder-part-2
Jan 3, 2024
Merged

feat(inverted_index): Add applier builder to convert Expr to Predicates (Part 2)#3068
zhongzc merged 9 commits intoGreptimeTeam:mainfrom
zhongzc:zhongzc/inverted-index-integration-applier-builder-part-2

Conversation

@zhongzc
Copy link
Copy Markdown
Collaborator

@zhongzc zhongzc commented Jan 2, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Continue #3034:

  • Compile the following exprs to predicates
    • And
    • Or
    • Eq
    • Lt, LtEq, Gt, GtEq
    • RegexMatch
    • InList

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2705

… to Predicates (Part 1)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
… to Predicates (Part 2)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc self-assigned this Jan 2, 2024
@github-actions github-actions Bot added docs-not-required This change does not impact docs. Size: L labels Jan 2, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c4d7b0d) 85.33% compared to head (7e5126c) 85.04%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
- Coverage   85.33%   85.04%   -0.29%     
==========================================
  Files         800      805       +5     
  Lines      129572   130658    +1086     
==========================================
+ Hits       110567   111115     +548     
- Misses      19005    19543     +538     

@zhongzc zhongzc force-pushed the zhongzc/inverted-index-integration-applier-builder-part-2 branch from b21459d to d0da869 Compare January 2, 2024 08:15
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Copy Markdown
Member

@v0y4g3r @evenyag Please take a look

Comment thread src/mito2/src/sst/index/applier/builder/comparison.rs Outdated
Copy link
Copy Markdown
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc enabled auto-merge January 3, 2024 05:05
@zhongzc zhongzc added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit b9302e4 Jan 3, 2024
@zhongzc zhongzc deleted the zhongzc/inverted-index-integration-applier-builder-part-2 branch January 3, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants