Skip to content

ci: add lto and strip to weekly build#841

Merged
waynexia merged 1 commit intodevelopfrom
ci/strip-weekly-build-size
Jan 6, 2023
Merged

ci: add lto and strip to weekly build#841
waynexia merged 1 commit intodevelopfrom
ci/strip-weekly-build-size

Conversation

@sunng87
Copy link
Copy Markdown
Member

@sunng87 sunng87 commented Jan 6, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Our weekly build is now over 200MB in size. Here I add strip and lto for weekly build.

This patch also disable cargo-sort until it's support for new workspace toml lands.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 requested review from evenyag, waynexia and zyy17 January 6, 2023 07:54
Copy link
Copy Markdown
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2023

Codecov Report

Merging #841 (f5c9ad9) into develop (627d444) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
+ Coverage    86.01%   86.03%   +0.01%     
===========================================
  Files          420      420              
  Lines        54976    54976              
===========================================
+ Hits         47290    47297       +7     
+ Misses        7686     7679       -7     
Flag Coverage Δ
rust 86.03% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sql/src/parser.rs 79.39% <0.00%> (-2.02%) ⬇️
src/datatypes/src/vectors/helper.rs 66.19% <0.00%> (+0.35%) ⬆️
src/servers/src/postgres/handler.rs 90.56% <0.00%> (+0.37%) ⬆️
src/common/substrait/src/df_expr.rs 30.81% <0.00%> (+0.65%) ⬆️
src/common/substrait/src/df_logical.rs 77.89% <0.00%> (+0.87%) ⬆️
src/servers/src/auth/user_provider.rs 85.18% <0.00%> (+2.46%) ⬆️
src/meta-client/src/rpc/util.rs 77.77% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 5b675f5 into develop Jan 6, 2023
@waynexia waynexia deleted the ci/strip-weekly-build-size branch January 6, 2023 08:20
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants