Skip to content

ci: fix release task by correcting output dir#853

Merged
waynexia merged 1 commit intodevelopfrom
ci/fix-release-task
Jan 10, 2023
Merged

ci: fix release task by correcting output dir#853
waynexia merged 1 commit intodevelopfrom
ci/fix-release-task

Conversation

@sunng87
Copy link
Copy Markdown
Member

@sunng87 sunng87 commented Jan 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This is a bug introduced in my previous introduction of weekly profile #841 . Our release script uses the output dir and with the new profile it has been changed to weekly.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 requested a review from zyy17 January 9, 2023 13:02
Copy link
Copy Markdown
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2023

Codecov Report

Merging #853 (1a9d37a) into develop (72f05a3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #853      +/-   ##
===========================================
- Coverage    86.26%   86.24%   -0.03%     
===========================================
  Files          418      418              
  Lines        54776    54776              
===========================================
- Hits         47253    47241      -12     
- Misses        7523     7535      +12     
Flag Coverage Δ
rust 86.24% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/table/scan.rs 85.18% <0.00%> (-5.56%) ⬇️
src/servers/src/error.rs 34.54% <0.00%> (-5.46%) ⬇️
src/servers/src/auth/user_provider.rs 82.71% <0.00%> (-2.47%) ⬇️
src/servers/src/opentsdb.rs 96.82% <0.00%> (-1.59%) ⬇️
src/common/substrait/src/df_expr.rs 30.16% <0.00%> (-0.66%) ⬇️
src/storage/src/write_batch.rs 99.24% <0.00%> (-0.26%) ⬇️
src/servers/src/mysql/writer.rs 71.31% <0.00%> (+0.77%) ⬆️
src/common/substrait/src/types.rs 52.88% <0.00%> (+0.96%) ⬆️
src/servers/src/mysql/handler.rs 69.04% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@waynexia waynexia merged commit ea753b9 into develop Jan 10, 2023
@waynexia waynexia deleted the ci/fix-release-task branch January 10, 2023 06:37
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants