feat: support default value when inserting data#854
feat: support default value when inserting data#854waynexia merged 1 commit intoGreptimeTeam:developfrom
Conversation
|
@killme2008 PTAL. Sorry for the slow progress, since I was suffering from covid-19 and busy work last few weeks. |
Codecov Report
@@ Coverage Diff @@
## develop #854 +/- ##
===========================================
- Coverage 86.32% 86.18% -0.14%
===========================================
Files 425 425
Lines 56097 56193 +96
===========================================
+ Hits 48426 48431 +5
- Misses 7671 7762 +91
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wish you health. We'll review it ASAP. Thanks a lot. |
b3e223d to
ba25788
Compare
ba25788 to
968a9da
Compare
|
@killme2008 @killme2008 Please take another look. |
waynexia
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @lizhemingi. I'll add some cases to sqlness test to cover this change.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
support default value when inserting data.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Identifierwithout quoted toPlaceholderinstead ofSingleQuotedStringwhen inserting data.PlaceholderwithdefaultandDEFAULTvalue to the default value of corresponding column if possible.Checklist
Refer to a related PR or issue link (optional)
#759