test: sqlness test for insert default#873
Merged
evenyag merged 5 commits intoGreptimeTeam:developfrom Jan 13, 2023
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
approved these changes
Jan 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #873 +/- ##
===========================================
- Coverage 86.25% 86.13% -0.12%
===========================================
Files 425 425
Lines 56638 56638
===========================================
- Hits 48853 48786 -67
- Misses 7785 7852 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Should we add a test like a column can not build a default value atomically(such as no default constraint TIME INDEX column) but use this default insert, and expect it will fail ? |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
lizhemingi
reviewed
Jan 13, 2023
Member
|
@waynexia CI / Sqlness Test (pull_request) Failing after 2m |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* test: sqlness test for insert default Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * empty line Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * add more sqls Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix typos Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update test according to typo fix Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add sqlness tests for INSERT DEFAULT implemented in #854.
cc @lizhemingi please take a look!
Checklist
Refer to a related PR or issue link (optional)