feat: remove backtrace from sql::error::Error#966
Merged
evenyag merged 2 commits intoGreptimeTeam:developfrom Feb 11, 2023
etolbakov:remove-backtrace-from-sql-error
Merged
feat: remove backtrace from sql::error::Error#966evenyag merged 2 commits intoGreptimeTeam:developfrom etolbakov:remove-backtrace-from-sql-error
evenyag merged 2 commits intoGreptimeTeam:developfrom
etolbakov:remove-backtrace-from-sql-error
Conversation
etolbakov
commented
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## develop #966 +/- ##
===========================================
- Coverage 86.05% 85.79% -0.26%
===========================================
Files 457 456 -1
Lines 61739 61684 -55
===========================================
- Hits 53129 52923 -206
- Misses 8610 8761 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Nice job! @etolbakov The Rustfmt check failed, could you fix it? |
Collaborator
Author
|
Thanks @evenyag 🙏 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: remove backtrace from sql::error::Error * fix: address formatting issues --------- Co-authored-by: Evgeny Tolbakov <evgeny.tolbakov@jpmorgan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Removed
backtracefromErrorenum.Please explain IN DETAIL what the changes are in this PR and why they are needed:
sql::error::Errorare unnecessary and might hurt performance since the parser would always return them while parsing an invalid SQL.Checklist
Refer to a related PR or issue link
#855