Skip to content

feat: remove backtrace from sql::error::Error #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evenyag merged 2 commits into from
Feb 11, 2023
Merged

feat: remove backtrace from sql::error::Error #966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8845dfb
feat: remove backtrace from sql::error::Error
Feb 9, 2023
d10f8a3
fix: address formatting issues
etolbakov Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions src/sql/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,7 @@ pub enum Error {
expr,
column_name
))]
UnsupportedDefaultValue {
column_name: String,
expr: Expr,
backtrace: Backtrace,
Comment thread
evenyag marked this conversation as resolved.
},
UnsupportedDefaultValue { column_name: String, expr: Expr },

// Syntax error from sql parser.
#[snafu(display("Syntax error, sql: {}, source: {}", sql, source))]
Expand All @@ -67,29 +63,22 @@ pub enum Error {
Tokenizer { sql: String, source: TokenizerError },

#[snafu(display("Missing time index constraint"))]
MissingTimeIndex { backtrace: Backtrace },
MissingTimeIndex {},

#[snafu(display("Invalid time index: {}", msg))]
InvalidTimeIndex { msg: String, backtrace: Backtrace },
InvalidTimeIndex { msg: String },

#[snafu(display("Invalid SQL, error: {}", msg))]
InvalidSql { msg: String, backtrace: Backtrace },
InvalidSql { msg: String },

#[snafu(display("Invalid column option, column name: {}, error: {}", name, msg))]
InvalidColumnOption {
name: String,
msg: String,
backtrace: Backtrace,
},
InvalidColumnOption { name: String, msg: String },

#[snafu(display("SQL data type not supported yet: {:?}", t))]
SqlTypeNotSupported {
t: crate::ast::DataType,
backtrace: Backtrace,
},
SqlTypeNotSupported { t: crate::ast::DataType },

#[snafu(display("Failed to parse value: {}", msg))]
ParseSqlValue { msg: String, backtrace: Backtrace },
ParseSqlValue { msg: String },

#[snafu(display(
"Column {} expect type: {:?}, actual: {:?}",
Expand All @@ -104,10 +93,10 @@ pub enum Error {
},

#[snafu(display("Invalid database name: {}", name))]
InvalidDatabaseName { name: String, backtrace: Backtrace },
InvalidDatabaseName { name: String },

#[snafu(display("Invalid table name: {}", name))]
InvalidTableName { name: String, backtrace: Backtrace },
InvalidTableName { name: String },

#[snafu(display("Invalid default constraint, column: {}, source: {}", column, source))]
InvalidDefault {
Expand All @@ -117,7 +106,7 @@ pub enum Error {
},

#[snafu(display("Unsupported ALTER TABLE statement: {}", msg))]
UnsupportedAlterTableStatement { msg: String, backtrace: Backtrace },
UnsupportedAlterTableStatement { msg: String },

#[snafu(display("Failed to serialize column default constraint, source: {}", source))]
SerializeColumnDefaultConstraint {
Expand All @@ -135,7 +124,7 @@ pub enum Error {
},

#[snafu(display("Invalid sql value: {}", value))]
InvalidSqlValue { value: String, backtrace: Backtrace },
InvalidSqlValue { value: String },

#[snafu(display(
"Converting timestamp {:?} to unit {:?} overflow",
Expand All @@ -145,7 +134,6 @@ pub enum Error {
TimestampOverflow {
timestamp: Timestamp,
target_unit: TimeUnit,
backtrace: Backtrace,
},
}

Expand Down