fix: describe distribute table#988
Merged
MichaelScofield merged 2 commits intoGreptimeTeam:developfrom Feb 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #988 +/- ##
===========================================
- Coverage 85.99% 85.96% -0.03%
===========================================
Files 431 432 +1
Lines 61557 62521 +964
===========================================
+ Hits 52934 53748 +814
- Misses 8623 8773 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
waynexia
reviewed
Feb 14, 2023
Member
waynexia
left a comment
There was a problem hiding this comment.
Is this bug only occur in a distributed table? Looks like find_primary_keys() also affects other modes.
Collaborator
Author
|
|
waynexia
approved these changes
Feb 14, 2023
sunng87
approved these changes
Feb 15, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: describe distribute table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fix a bug that
DESC tableis not working correctly for distribute table when primary keys are defined in column options.Also:
Checklist
Refer to a related PR or issue link (optional)
close #923