Implement status reduction script command. #2246
Conversation
Emistry
added
component:scripts
|
This change is |
src/map/script.c
Outdated
| int val = script_getnum(st, 3);; | ||
| struct map_session_data *sd = script->rid2sd(st); | ||
|
|
||
| if (sd != NULL) |
There was a problem hiding this comment.
will be script error if sd not attached.
probably better return some error status in this case?
There was a problem hiding this comment.
wait, aren't the script->rid2sd(st) would throw the error status if sd == NULL?
There was a problem hiding this comment.
i mean bit other. yes error in server console is fine
but current code also terminate npc script, because here no pushint in else branch.
if you add pushint also on errors, npc script can get result and continue running
There was a problem hiding this comment.
ops, rid2sd terminating script already. then probably better replace rid2sd to map->id2sd(st->rid)
There was a problem hiding this comment.
i think its better to remain script->rid2sd(st);.
the script command are designed for player to retrieve that status points.
Its fine to terminate the script if no player are attached to it, just like any other script commands like *statusup() etc
Emistry
force-pushed
the
scriptcommand_pcneedstatuspoint
branch
from
eae4dbc to
5166976
Compare
npc/other/CashShop_Functions.txt
Outdated
| // - Returns status points equals to points needed to raise | ||
| // that stat to original value. | ||
| // - Doesn't work if base status <type> would become lower than 1 after reduction. | ||
| // * callfunc("F_CashReduceStat",<type>{,<val>,<itemid>}); |
There was a problem hiding this comment.
please correct the style issues in this function, spaces after , and if and parenthesis for script command calls.
- for stat reduction support. - return the amount of status point required to increase a status.
Emistry
force-pushed
the
scriptcommand_pcneedstatuspoint
branch
from
5166976 to
d7bbebd
Compare
6 participants
Pull Request Prelude
Changes Proposed
Affected Branches: Master
Issues addressed: #1234
References rathena/rathena@51ef911
Known Issues and TODO List