Skip to content

Conversation

@AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

thanks to @Emistry showing me this link #2246
we actually don't support <char_id> field, unlike rathena counterpart

Changes Proposed

Fix *needed_status_point not support <char_id> field

Affected Branches

  • Master

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry added component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder labels Mar 3, 2019
@hemagx
Copy link
Contributor

hemagx commented Mar 5, 2019

seems like your git client is not set correctly, the email is not matching your github email, all commits can't be traced back to you.

@dastgirp dastgirp added this to the Release v2019.03.10 milestone Mar 9, 2019
@MishimaHaruna MishimaHaruna merged commit 0d7b360 into HerculesWS:master Mar 11, 2019
@AnnieRuru AnnieRuru deleted the 70-needed_status_point branch March 11, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants