Modified skill_cooldown_save() to ignore guild skills if guild_skill_relog_delay is set to 1. #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relog_delay is set to 1. If guild skills are not ignored when guild_skill_relog_delay is set to 1, the map server will throw error messages if the guild master relogs while cooldown. Also applied Hercules coding style to skill_cooldown_save(). See HerculesWS#2591
Kenpachi2k13
added
type:bug
4144
approved these changes
Dec 1, 2019
Kenpachi2k13
added
codereview:accepted
MishimaHaruna
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Guild skills will be ignored in
skill_cooldown_save()ifguild_skill_relog_delayis set to 1.If guild skills are not ignored when
guild_skill_relog_delayis set to 1, the map server will throw error messages (no such timer) if the guild master relogs while cooldown.Also applied Hercules coding style to
skill_cooldown_save().Issues addressed: #2591