-
Notifications
You must be signed in to change notification settings - Fork 772
Add flag to ignore mapflag restrictions in warpparty() and warpguild() script commands. #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Asheraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this silently breaks every script that relies on these commands checking the map restrictions, you can either introduce a flag to enable/disable these checks (defaults to enabled), or go with the suggestion in the related issue to deprecate these commands and merge them into warp().
|
There is no script that relies on that restrictions. |
|
I am not talking about the scripts included with the repository (those can always be fixed), but the tens of thousands of scripts written by the community since these commands were introduced a long long time ago, unfortunately opinions on how it should work does not matter here, the scripting engine MUST ALWAYS keep backward compatibility, unless you stop the script from loading you cannot change the behavior in a manner that breaks that compatibility. |
… disable them as requested.
5e1eec4 to
d1438cb
Compare
… disable them as requested.
|
Ah, okay. You're right. Thanks for pointing that out. As a side note: |
|
Hmm im not sure if i like inserting the new argument in the middle and that offset changing even though it works, anyways you missed updating the building definition with an extra optional argument. |
…and `warpguild()`.
|
I did not put the flag at he end of the argument lists, because this would force the user to pass a |
Pull Request Prelude
Changes Proposed
warpparty()andwarpguild()script commands.warpparty()andwarpguild()script commands.Issues addressed: #1861