Skip to content

formulae: use [email protected] to build #154540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 21, 2023
Merged

formulae: use [email protected] to build #154540

merged 8 commits into from
Nov 21, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 16, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Was not fully tested in #153883

Dependents need to be built as most ghc formulae are statically linked.

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Nov 16, 2023
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Nov 16, 2023
@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2023
@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 18, 2023
@cho-m cho-m changed the title ghc: test formulae: use [email protected] to build Nov 20, 2023
@cho-m cho-m marked this pull request as ready for review November 20, 2023 23:14
@cho-m cho-m mentioned this pull request Nov 20, 2023
Merged
6 tasks
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 21, 2023
@cho-m cho-m removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Nov 21, 2023
@github-actions github-actions bot added the haskell Haskell use is a significant feature of the PR or issue label Nov 21, 2023
@cho-m cho-m mentioned this pull request Nov 21, 2023
Merged
6 tasks
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 21, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Homebrew:master with commit 40a177f Nov 21, 2023
@cho-m cho-m deleted the ghc-test branch November 26, 2023 13:50
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. haskell Haskell use is a significant feature of the PR or issue long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @iMichka @BrewTestBot @p-linnane