Skip to content

cabal-install 3.10.2.1 #154836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added haskell Haskell use is a significant feature of the PR or issue CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Nov 19, 2023
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 19, 2023
@p-linnane p-linnane added long build Set a long timeout for formula testing CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Nov 20, 2023
@p-linnane p-linnane force-pushed the cabal-install-3.10.2.1 branch from 1a5e900 to 6a9a9cc Compare November 20, 2023 02:34
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 20, 2023
@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 20, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 20, 2023
@iMichka
Copy link
Member

iMichka commented Nov 20, 2023

Many errors here ... I think I would recommend to update the cabal install used inside ghc to align versions. That helped last time I did the ghc migration.

@cho-m
Copy link
Member Author

cho-m commented Nov 20, 2023

Haven't had chance to check, but I think many errors are probably because we didn't test them in GHC 9.8 release. I have another PR to work on these.

@cho-m
Copy link
Member Author

cho-m commented Nov 20, 2023

Following dependents are failing on GHC 9.8 (see #154540)

  • dhall-bash
  • dhall-json
  • git-annex
  • hlint
  • pandoc
  • pandoc-crossref
  • stylish-haskell
  • texmath

New failures are:

  • fourmolu, ghcup, haskell-language-server, ormolu: All failing with similar message so may be related to cabal-install-3.10 fails with header files in 'c-sources' haskell/cabal#9190 and corresponding references.
      Warning: The following files listed in the main library's c-sources will not
      be used: <filename>.
      Header files should be in the 'include' or 'install-include' stanza.
      See https://cabal.readthedocs.io/en/3.10/cabal-package.html#pkg-field-includes
    
  • taskell - may need to deprecate as the old brick doesn't seem to build anymore and upstream is in low/no maintenance state. taskell: fix build with vty constraint #154976

@cho-m cho-m added the upstream issue An upstream issue report is needed label Nov 20, 2023
@cho-m
Copy link
Member Author

cho-m commented Nov 21, 2023

ghcup is only failure that remains after we merge PR #154540. I am checking with Cabal upstream on what is way to handle c-sources changes for Objective-C files as that is causing failure when compiling streamly https://github.com/composewell/streamly/blob/master/streamly.cabal#L459

  Warning: The following files listed in the main library's c-sources will not
  be used: src/Streamly/Internal/FileSystem/Event/Darwin.m.
  Header files should be in the 'include' or 'install-include' stanza.
  See https://cabal.readthedocs.io/en/3.10/cabal-package.html#pkg-field-includes
  ar: dist/build/src/Streamly/Internal/FileSystem/Event/Darwin.o: No such file or directory
  Error: cabal: Failed to build streamly-0.8.3 (which is required by exe:ghcup
  from ghcup-0.1.20.0). See the build log above for details.

@cho-m cho-m force-pushed the cabal-install-3.10.2.1 branch from 6a9a9cc to 591cb46 Compare November 21, 2023 17:02
@cho-m cho-m force-pushed the cabal-install-3.10.2.1 branch from 591cb46 to 73f2bc3 Compare December 12, 2023 03:27
@cho-m cho-m force-pushed the cabal-install-3.10.2.1 branch from 73f2bc3 to e88e048 Compare December 28, 2023 21:47
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 6, 2024
@iMichka iMichka force-pushed the cabal-install-3.10.2.1 branch from e88e048 to 0c446c6 Compare January 6, 2024 14:07
@iMichka
Copy link
Member

iMichka commented Jan 6, 2024

Same issue with git-annex:

 Failed to build hfsevents-0.1.6.
  Build log (
  /private/tmp/git-annex-20240106-81217-knz79z/git-annex-10.20231227/.brew_home/.cache/cabal/logs/ghc-9.6.3/hfsvnts-0.1.6-a910fc59.log
  ):
  Configuring library for hfsevents-0.1.6..
  clang: warning: -Wl,-headerpad_max_install_names: 'linker' input unused [-Wunused-command-line-argument]
  clang: warning: argument unused during compilation: '-L/opt/homebrew/opt/[email protected]/lib' [-Wunused-command-line-argument]
  clang: warning: argument unused during compilation: '-L/opt/homebrew/lib' [-Wunused-command-line-argument]
  clang: warning: argument unused during compilation: '-L/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries' [-Wunused-command-line-argument]
  Preprocessing library for hfsevents-0.1.6..
  Building library for hfsevents-0.1.6..
  [1 of 1] Compiling System.OSX.FSEvents ( System/OSX/FSEvents.hs, dist/build/System/OSX/FSEvents.o, dist/build/System/OSX/FSEvents.dyn_o )
  ar: dist/build/cbits/c_fsevents.o: No such file or directory
  Error: cabal: Failed to build hfsevents-0.1.6 (which is required by
  git-annex-10.20231227). See the build log above for details.

@cho-m
Copy link
Member Author

cho-m commented Jan 6, 2024

Let me try a different workaround in cabal-install. Want to locally build a few dependents to see if we can drop rebuilding them here.

@cho-m cho-m force-pushed the cabal-install-3.10.2.1 branch from 0c446c6 to 3efadc4 Compare January 7, 2024 01:27
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jan 7, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 7, 2024
@cho-m
Copy link
Member Author

cho-m commented Jan 8, 2024

Should be good now. Remaining failure is unrelated test bot issue where it incorrectly tries to source build some dependencies.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 9, 2024
@BrewTestBot BrewTestBot enabled auto-merge January 9, 2024 02:25
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 9, 2024
Merged via the queue into Homebrew:master with commit f629ac1 Jan 9, 2024
@cho-m cho-m deleted the cabal-install-3.10.2.1 branch March 1, 2024 16:11
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. haskell Haskell use is a significant feature of the PR or issue long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants