Skip to content

coccinelle: add missing pcre dependency and fix revision hash #78109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fix failures from #75169

Minor re-tag due to version number / changelog commit:
coccinelle/coccinelle@e84d3dd...25e7cee

pcre is a build/runtime dependency:

  • Build:
    checking for libpcre... yes
    configure: configuring package pcre
    
  • Test:
    dyld: Library not loaded: /usr/local/opt/pcre/lib/libpcre.1.dylib
      Referenced from: /usr/local/Cellar/coccinelle/1.1.0_1/bin/spatch
      Reason: image not found
    Error: coccinelle: failed
    

pkg-config is optional (fallback is used if unavailable), but might as well add since recommended:
https://github.com/coccinelle/coccinelle/blob/master/install.txt

pkg-config (optional, but strongly recommended)

@BrewTestBot BrewTestBot added the ocaml OCaml use is a significant feature of the PR or issue label May 26, 2021
depends_on "ocaml"
depends_on "pcre"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use pcre2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried. I mainly based on other formula that use both ocaml and pcre:

haxe.rb
37:  depends_on "pcre"

comby.rb
22:  depends_on "pcre"

semgrep.rb
30:  depends_on "pcre"

Looking at discussion in pcre-ocaml mmottl/pcre-ocaml#10 it sounds like there was no plan to support pcre2 unless someone else contributed it.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the coccinelle-fix-build branch May 26, 2021 22:10
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ocaml OCaml use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants