chore: Release - dev → rc #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allow to manage volume using native pipewire utilities, if audioserver is running by PipeWire. If volume is managed throug Pulse Audio when the actual audio server is pipewire this leads to audio stream is recreated every time any parameter is changed: - muted - unmuted - volume changes This behaviour leads to some inconvenience: - Any equalizer/filter/etc applied to physical sink is discarded when stream is recreated - Waybar crashes on eq discard for some reason - Virtual sink should be used as workaround Managing volume natively by pipewire utils solves all mentioned problems.
# Pull Request ## Description This feature allow to manage volume using native pipewire utilities, if audioserver is running by PipeWire. If volume is managed throug Pulse Audio when the actual audio server is pipewire this leads to audio stream is recreated every time any parameter is changed: - muted - unmuted - volume changes This behaviour leads to some inconvenience: - Any equalizer/filter/etc applied to physical sink is discarded when stream is recreated - Waybar crashes on eq discard for some reason - Virtual sink should be used as workaround Managing volume natively by pipewire utils solves all mentioned problems. ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Additional context > [!WARNING] > I have tested it only on my PC and my laptop, which are both AMD-only and have pretty similar audio configs. I will appreciate if someone can test this on different configurations
# Pull Request ## Description Small simplification of window rules for `xdg-desktop-portal-gtk`. These is no need to explicitly add `float` rule because window will be floating from `common-popups` tag rules ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [x] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed.
1. Duplicated rules removed
2. Specific rules which are overlapped by more broad once removed i.e.
```hyprlang
windowrule = float,class:^(firefox)$,title:^(Library)$
```
is overlapped by
```hyprlang
windowrule = tag +common-popups,title:^(Library)(.*)$
```
3. All popups rules moved to
`Configs/.local/share/hypr/windowrules.conf`
4. PIP rules made more readable with help of tags
# Pull Request
## Description
This PR try to simplify window rules provided by HyDE without
sacrificing any functionality.
What was done here:
1. Duplicated rules removed
2. Specific rules which are overlapped by more broad once removed
i.e.
windowrule = float,class:^(firefox)$,title:^(Library)$
is overlapped by
windowrule = tag +common-popups,title:^(Library)(.*)$
4. All popups rules moved to
`Configs/.local/share/hypr/windowrules.conf`
5. PIP rules made more readable with help of tags
## Type of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that would cause existing
functionality to not work as expected)
- [ ] **Documentation update** (non-breaking change; modified files are
limited to the documentations)
- [x] **Technical debt** (a code change that does not fix a bug or add a
feature but makes something clearer for devs)
- [ ] **Other** (provide details below)
## Checklist
- [x] I have read the
[CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md)
document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the [commit
guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [x] I have tested my code locally and it works as expected.
- [ ] All new and existing tests passed.
Merged
kRHYME7
added a commit
that referenced
this pull request
Oct 4, 2025
This is an automated PR to promote changes from `rc` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **1st or 3rd Friday of the month** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore chore: Release - dev → rc (#1313) (df7300b) by Khing * chore Merge branch 'rc' into dev (c5811d3) by Khing * chore techdebt: window rules tided up (#1318) (31f02d4) by Khing * chore techdebt: window rules tided up (d16be41) by Ilya Bogdanov * fix: simplify window rules for `xdg-desktop-portal-gtk` (#1317) (b54ee34) by Khing * chore Merge branch 'dev' into small-fix-for-windowrules (c009b13) by Khing * feat: add pipewire support for `volumecontrol.sh` (#1316) (900b573) by Khing * fix: simplify window rules for `xdg-desktop-portal-gtk` (e9b13de) by Ilya Bogdanov * chore `volumecontrol.sh`: add changelog entry (0cd3484) by Ilya Bogdanov * feat: add pipewire support for `volumecontrol.sh` (41b0df3) by Ilya Bogdanov * chore Feat: Let Users modify there own config.fish (1d7e686) by kRHYME7 * chore Merge branch 'rc' into dev (94e7383) by Khing * chore Closes [Feature Request]: Framework-Specific Font Configuration Support for High-DPI Displays Fixes #1309 (975982b) by kRHYME7 * chore Merge branch 'rc' into dev (95f9ca4) by Khing * chore open dev PR (bf19663) by kRHYME7 * chore chore: Release - dev → rc (#1277) (a2ca5e9) by Khing * chore Merge branch 'rc' into dev (c8218e6) by Khing * chore Merge branch 'master' into rc (e13c1d6) by Khing * chore Fix broken fresh installation (3b17984) by kRHYME7 * chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into dev (b34b7c2) by kRHYME7 * chore Merge branch 'rc' into dev (8be8555) by Khing * chore open rc PR (df39892) by kRHYME7 * chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into dev (bbb35c3) by kRHYME7 * chore Merge branch 'rc' into dev (f620a7a) by Khing * fixes (cb3c99c) by kRHYME7 * chore Merge branch 'rc' into dev (ed3698e) by Khing * feat: use `bat` as improvement of `cat` for fish shell (#822) (80c4a6a) by Khing * chore Merge branch 'dev' into replace-cat-with-bat (c021302) by Rubin Bhandari * fixups after rebase (7906c0a) by Ilya Bogdanov * fix: prevent bat output colors when piped (638e997) by Ilya Bogdanov * fix: move `eza` and `duf` to pkg_extra for fish shell (ea002ac) by Ilya Bogdanov * fix: move `bat` from pkg_core to pkg_extra (fec279e) by Ilya Bogdanov * chore Merge branch 'dev' into replace-cat-with-bat (80eaa9e) by Ilya Bogdanov * chore Merge branch 'dev' into replace-cat-with-bat (cfa64b1) by Khing * fix: remove duplicate fzf option (06d8622) by Ilya Bogdanov --- Please review the changes carefully before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR to promote changes from
devtorc.Please review and test before merging.
See TESTING.md for complete testing instructions.
According to our release policy, this PR is expected to be merged during: Freeze Week (see release policy)
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the project.
xdg-desktop-portal-gtk(fix: simplify window rules forxdg-desktop-portal-gtk#1317) (b54ee34) by Khingvolumecontrol.sh(feat: add pipewire support forvolumecontrol.sh#1316) (900b573) by Khingxdg-desktop-portal-gtk(e9b13de) by Ilya Bogdanovvolumecontrol.sh: add changelog entry (0cd3484) by Ilya Bogdanovvolumecontrol.sh(41b0df3) by Ilya BogdanovPlease review the changes carefully before merging.