Skip to content

Conversation

@zeerayne
Copy link
Contributor

Pull Request

Description

This PR offers two features:

  1. Make output of cat more readable by adding syntax highlightning
  2. Make output of any command run with -h or --help argument more readable by adding syntax highlightning

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

cat

Before

image

After

image

--help

Before

image

After

image

@zeerayne
Copy link
Contributor Author

Well, looks like this conflicts with #819

@zeerayne zeerayne force-pushed the replace-cat-with-bat branch from 9bf0c04 to 03950da Compare June 16, 2025 13:15
@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 16, 2025

what happens if one runs a zsh script will the alias be skipped?

@zeerayne
Copy link
Contributor Author

what happens if one runs a zsh script will the alias be skipped?

Aliases can be deleted/skipped safely:

  • Original cat will be used instead of bat w/o any issues if no aliases were applied.
  • For commands with --help/-h options no post-processing and syntax coloring will be applied (also original behaviour).

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 16, 2025

Aliases can be deleted/skipped safely:

Is it automatic or Scripts should use realpath to avoid mangling with aliases?

@kRHYME7 kRHYME7 mentioned this pull request Jun 16, 2025
@zeerayne
Copy link
Contributor Author

Is it automatic or Scripts should use realpath to avoid mangling with aliases?

Good question, I will check it additionally

@zeerayne
Copy link
Contributor Author

@kRHYME7 scripts ignore aliases and use native commands instead

image

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 23, 2025

This changes can be added as ./functions or ./conf.d following this PR #858

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 23, 2025

ops my bad is this for fish only?

@zeerayne
Copy link
Contributor Author

Nope, this is both for zsh and fish

@zeerayne
Copy link
Contributor Author

This changes can be added as ./functions or ./conf.d following this PR #858

Will check later & refactor this PR

@zeerayne zeerayne force-pushed the replace-cat-with-bat branch from 46b88b2 to 916d276 Compare June 23, 2025 11:41
@zeerayne zeerayne changed the title feat: use bat as improvement of cat feat: use bat as improvement of cat for fish shell Jun 23, 2025
@zeerayne
Copy link
Contributor Author

This PR is now fish-only. zsh version moved to other PR #860

@zeerayne zeerayne force-pushed the replace-cat-with-bat branch 2 times, most recently from e96d9e3 to 71269f9 Compare June 24, 2025 18:53
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Sep 11, 2025

status? @zeerayne

@zeerayne
Copy link
Contributor Author

Looks like conflicts should be resolved. Will do it later today

@kRHYME7 kRHYME7 marked this pull request as draft September 11, 2025 16:01
@kRHYME7
Copy link
Contributor

kRHYME7 commented Sep 11, 2025

no rush, tyt

@zeerayne zeerayne force-pushed the replace-cat-with-bat branch from 39e2c08 to 0b135af Compare September 11, 2025 20:00
@zeerayne zeerayne force-pushed the replace-cat-with-bat branch from 0b135af to 7906c0a Compare September 11, 2025 20:05
@zeerayne
Copy link
Contributor Author

Well, now PR looks good

@zeerayne zeerayne marked this pull request as ready for review September 11, 2025 20:06
@kRHYME7 kRHYME7 requested review from prime-run and rubiin September 15, 2025 07:49
Copy link
Contributor

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets ask @prime-run to review

@kRHYME7
Copy link
Contributor

kRHYME7 commented Sep 16, 2025

merging then

@kRHYME7 kRHYME7 merged commit 80c4a6a into HyDE-Project:dev Sep 16, 2025
4 checks passed
kRHYME7 added a commit that referenced this pull request Sep 27, 2025
This is an automated PR to promote changes from `dev` to `rc`.
Please review and test before merging.

See [TESTING.md](./TESTING.md) for complete testing instructions.

According to our release policy, this PR is expected to be merged
during: **Freeze Week (see release policy)**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* chore Merge branch 'rc' into dev (c8218e6) by Khing
* chore Fix  broken fresh installation (3b17984) by kRHYME7
* chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into
dev (b34b7c2) by kRHYME7
* chore Merge branch 'rc' into dev (8be8555) by Khing
* chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into
dev (bbb35c3) by kRHYME7
* chore Merge branch 'rc' into dev (f620a7a) by Khing
* fixes (cb3c99c) by kRHYME7
* chore Merge branch 'rc' into dev (ed3698e) by Khing
* feat: use `bat` as improvement of `cat` for fish shell (#822)
(80c4a6a) by Khing
* chore Merge branch 'dev' into replace-cat-with-bat (c021302) by Rubin
Bhandari
* fixups after rebase (7906c0a) by Ilya Bogdanov
* fix: prevent bat output colors when piped (638e997) by Ilya Bogdanov
* fix: move `eza` and `duf` to pkg_extra for fish shell (ea002ac) by
Ilya Bogdanov
* fix: move `bat` from pkg_core to pkg_extra (fec279e) by Ilya Bogdanov
* chore Merge branch 'dev' into replace-cat-with-bat (80eaa9e) by Ilya
Bogdanov
* chore Merge branch 'dev' into replace-cat-with-bat (cfa64b1) by Khing
* fix: remove duplicate fzf option (06d8622) by Ilya Bogdanov
---

Please review the changes carefully before merging.
@github-actions github-actions bot mentioned this pull request Sep 27, 2025
kRHYME7 added a commit that referenced this pull request Oct 4, 2025
This is an automated PR to promote changes from `rc` to `master`.
Please review and test before merging.

See [TESTING.md](./TESTING.md) for complete testing instructions.

According to our release policy, this PR is expected to be merged on:
**1st or 3rd Friday of the month**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* chore chore: Release - dev → rc (#1313) (df7300b) by Khing
* chore Merge branch 'rc' into dev (c5811d3) by Khing
* chore techdebt: window rules tided up (#1318) (31f02d4) by Khing
* chore techdebt: window rules tided up (d16be41) by Ilya Bogdanov
* fix: simplify window rules for `xdg-desktop-portal-gtk` (#1317)
(b54ee34) by Khing
* chore Merge branch 'dev' into small-fix-for-windowrules (c009b13) by
Khing
* feat: add pipewire support for `volumecontrol.sh` (#1316) (900b573)
by Khing
* fix: simplify window rules for `xdg-desktop-portal-gtk` (e9b13de) by
Ilya Bogdanov
* chore `volumecontrol.sh`: add changelog entry (0cd3484) by Ilya
Bogdanov
* feat: add pipewire support for `volumecontrol.sh` (41b0df3) by Ilya
Bogdanov
* chore Feat: Let Users modify there own config.fish (1d7e686) by
kRHYME7
* chore Merge branch 'rc' into dev (94e7383) by Khing
* chore Closes [Feature Request]: Framework-Specific Font Configuration
Support for High-DPI Displays Fixes #1309 (975982b) by kRHYME7
* chore Merge branch 'rc' into dev (95f9ca4) by Khing
* chore open dev PR (bf19663) by kRHYME7
* chore chore: Release - dev → rc (#1277) (a2ca5e9) by Khing
* chore Merge branch 'rc' into dev (c8218e6) by Khing
* chore Merge branch 'master' into rc (e13c1d6) by Khing
* chore Fix  broken fresh installation (3b17984) by kRHYME7
* chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into
dev (b34b7c2) by kRHYME7
* chore Merge branch 'rc' into dev (8be8555) by Khing
* chore open rc PR (df39892) by kRHYME7
* chore Merge branch 'dev' of https://github.com/HyDE-Project/HyDE into
dev (bbb35c3) by kRHYME7
* chore Merge branch 'rc' into dev (f620a7a) by Khing
* fixes (cb3c99c) by kRHYME7
* chore Merge branch 'rc' into dev (ed3698e) by Khing
* feat: use `bat` as improvement of `cat` for fish shell (#822)
(80c4a6a) by Khing
* chore Merge branch 'dev' into replace-cat-with-bat (c021302) by Rubin
Bhandari
* fixups after rebase (7906c0a) by Ilya Bogdanov
* fix: prevent bat output colors when piped (638e997) by Ilya Bogdanov
* fix: move `eza` and `duf` to pkg_extra for fish shell (ea002ac) by
Ilya Bogdanov
* fix: move `bat` from pkg_core to pkg_extra (fec279e) by Ilya Bogdanov
* chore Merge branch 'dev' into replace-cat-with-bat (80eaa9e) by Ilya
Bogdanov
* chore Merge branch 'dev' into replace-cat-with-bat (cfa64b1) by Khing
* fix: remove duplicate fzf option (06d8622) by Ilya Bogdanov
---

Please review the changes carefully before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants