fix: improve mediaplayer.py max_length behavior in case of extremely long artist and track
#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y long artist and track
Contributor
|
Thanks!! |
kRHYME7
added a commit
that referenced
this pull request
May 30, 2025
This is an automated PR to promote changes from `dev` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **Friday** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore Merge branch 'master' into dev (2db2112) by Khing * fix: improve mediaplayer.py `max_length` behavior in case of extremely long artist and track (#701) (bb1ed13) by Ilya Bogdanov * feat: add keybinding for rofi animation select menu (#698) (0464c8d) by Rubin Bhandari * feat: add keybinding for rofi animation select menu (d534f61) by Ilya Bogdanov * feat: use `duf` as alias for `df` (#693) (f9fd4b6) by Rubin Bhandari * chore Merge branch 'dev' into feature-duf (7aef008) by Rubin Bhandari * chore Add Optimized Animation Config and Enhanced IBM Hyprlock Theme (#681) (7e1ba15) by Rubin Bhandari * chore Merge branch 'dev' into master (bf58a9b) by Rubin Bhandari * feat: use `duf` as alias for `df` (2373b81) by Ilya Bogdanov * doc: remove copied line (#688) (adb788d) by ProfShiba * fix: change config names in `uninstall.sh` note to actual values (#684) (81eacca) by Ilya Bogdanov * chore Adding enhanced IBM hyprlock with transparency, and blur support (0e2953c) by xaicat * chore LimeFrenzy - An optimized animation config with smooth and fluent transitions (8f92b21) by xaicat * fix: explicitly mention playerctl (#679) (4f0b15d) by Rubin Bhandari * fix: systemupdate (a99a15a) by kRHYME7 * fix: systemupdate (a584569) by kRHYME7 * fix: update hypridle config syntax (#676) (ba6c273) by Rubin Bhandari * fix: Fix #677/graphic-loading for non-interactive shell (#678) (d8eb7f9) by Rubin Bhandari * chore Update Configs/.user.zsh (ffa2db0) by Rubin Bhandari * chore Merge branch 'master' into dev (d538f66) by Khing * fix: Fix #677 graphic-loading for non-interactive shell (8ed764d) by comrumino * feat: Add dropdown terminal (#673) (29e0b0e) by Rubin Bhandari * doc: add dropdown terminal keybind (2d72567) by ProfShiba * chore Update keybindings.conf (6d17828) by Khing * chore Merge branch 'dev' into dropdown (d23f742) by Khing * chore Merge branch 'master' into dev (d71b42b) by Khing * chore Update Configs/.config/hypr/keybindings.conf (1e91a5f) by Rubin Bhandari * chore Merge branch 'dev' into dropdown (2f398db) by Rubin Bhandari * fix: Some QOL (cdb73c1) by kRHYME7 * chore Shaders (#656) (813e13b) by Khing * feat: dropdown terminal (14e7b4c) by ProfShiba * fix: includes the XDG cache directory in the discord wallbash script (#671) (2a5e8a5) by Keegan Wright * chore config: update .zshrc and .zshenv to reference .user.zsh instead of .hyde.zshrc (#668) (b0e6d71) by dagiikg9134 * fix: Missing scrollbars on Discord Clients (#666) (ebdd8a9) by Xyloflake * chore Merge branch 'master' into dev (acf8ec0) by Khing * docs: add custom keybinding example for gamelauncher.sh (#518) (0844927) by jacob --- Please review the changes carefully before merging.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Current flow limits only track length, but does not touch artist. This can cause overflowing a desired max length a lot in some cases.
I want to offer improved length limiting flow, which proportionally limits length of artist and track.
Type of change
Checklist
Screenshots
Mediaplayer settings
Before
After