feat: customizable separator for mediaplayer.py #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for a configurable separator between artist and track in the media player.
- Introduces a new
artist_track_separatorsetting in both JSON and TOML schemas. - Updates
mediaplayer.pyto read the separator fromMEDIAPLAYER_ARTIST_TRACK_SEPARATORand apply it in the formatted output.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Configs/.local/share/hyde/schema/config.toml.json | Added artist_track_separator property in JSON schema |
| Configs/.local/share/hyde/schema/config.toml | Added artist_track_separator property in TOML schema |
| Configs/.local/lib/hyde/mediaplayer.py | Loaded new env var and replaced hardcoded separator |
Comments suppressed due to low confidence (1)
Configs/.local/lib/hyde/mediaplayer.py:97
- No tests cover the new custom separator logic in format_artist_track; consider adding unit tests for cases when MEDIAPLAYER_ARTIST_TRACK_SEPARATOR is applied.
output_text = f"{prefix}{prefix_separator}<i>{artist}</i>{artist_track_separator}<b>{track}</b>"
This was referenced Jun 1, 2025
This was referenced Jun 4, 2025
kRHYME7
added a commit
that referenced
this pull request
Jun 6, 2025
This is an automated PR to promote changes from `dev` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **Friday** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * fix(hyprlock) : minor fix (b7566f0) by kRHYME7 * chore Merge branch 'master' into dev (c461d04) by Khing * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (c8a9501) by kRHYME7 * chore ✨ (4528ca7) by kRHYME7 * chore Merge branch 'master' into dev (a9b3518) by Khing * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (374c640) by kRHYME7 * chore start hyprsunset via statefile (2366622) by kRHYME7 * fix: set resonable waybar tray spacing (#744) (a4243be) by Ilya Bogdanov * chore refactor: Hyprsunset (4ab1c9f) by kRHYME7 * fix: #739 (27b5da3) by kRHYME7 * feat: add hyde-menu module to all hyprdots-ported layouts (#740) (04eef1d) by Ilya Bogdanov * fix(zsh): Syntax error (d3ba6a1) by kRHYME7 * fix: make waybar ignore example layouts (#742) (6146a46) by Ilya Bogdanov * chore refactor: waybar.py considers font & icon values from config.toml (#743) (12d8c1c) by Ilya Bogdanov * fix(waybar): revert example as being used by users (1e63e69) by kRHYME7 * fix: Do not use active first for taskbar (6f9fdd5) by kRHYME7 * fix(waybar): Fixes updates module (6098938) by kRHYME7 * feat(waybar): added `waybar.scale` to change waybar font-size (0219627) by kRHYME7 * chore Update Configs/.config/hypr/windowrules.conf (52ce1c1) by Khing * feat: adding some bottom bars (ace7c6b) by kRHYME7 * chore breaking: Waybar Restructured. (fe1b15e) by Khing * fix: no reboot option after installation (#721) (d4aefe7) by amit * chore config: fixed windowrule regex that matches unintended windows (#724) (ded4f96) by denisu14 * fix: mediaplayer.py `artist_track_separator` refers to undefined var (#723) (afc3312) by Ilya Bogdanov * feat: disable gtk window control buttons by default (#722) (7b55b0e) by Ilya Bogdanov * fixed version (#718) (c86f16a) by Konstantin Rasputin * chore Feat : Query before showing image in fastfetch (2b295eb) by kRHYME7 * fix: migrate window rules to new syntax (#697) (6f78180) by Ilya Bogdanov * feat: customizable separator for mediaplayer.py (#710) (f988ae9) by Ilya Bogdanov * docs: To disable command not found handler for zshrc! (7d435f8) by kRHYME7 * chore Merge branch 'master' into dev (fd25938) by Khing * fix: fix issue 713 (#714) (314cf20) by Konstantin Rasputin * fix: fix issue 708: typos in starship config (#712) (82de0f7) by Konstantin Rasputin * feat: add keybinding for hyprlock layout select menu (#699) (66406cd) by Rubin Bhandari * chore Merge branch 'dev' into hyprlock-keybinding (2b29001) by Rubin Bhandari * fix: mediaplayer conditions now work properly (#706) (c16544b) by Ilya Bogdanov * chore Merge branch 'dev' into hyprlock-keybinding (52e15eb) by Rubin Bhandari * fix: pasting (7eb1208) by kRHYME7 --- Please review the changes carefully before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Small feature for
mediaplayer.py- ability to change separator between artist and track to any custom one.Type of change
Checklist
Screenshots
Default
With custom config