Skip to content

fix: fix issue 708: typos in starship config #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kRHYME7 merged 1 commit into from
Jun 1, 2025
Merged

fix: fix issue 708: typos in starship config #712

kRHYME7 merged 1 commit into from
Jun 1, 2025

Conversation

@rasputyashka
Copy link
Contributor

@rasputyashka rasputyashka commented Jun 1, 2025

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • Make sure to make PR against dev and not the master
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@rasputyashka
Copy link
Contributor Author

rasputyashka commented Jun 1, 2025

I also think it's a good idea to have a docstring that says something like 'you can safely edit this file. We would also recommend not to use concrete colors (like #cccccc) if you want your colors to match the current theme'

@rasputyashka rasputyashka mentioned this pull request Jun 1, 2025
Closed
@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 1, 2025

I don't know, I still love p10k. Just open a PR we can discuss about it there.

@rasputyashka
Copy link
Contributor Author

rasputyashka commented Jun 1, 2025

Well, the PR does not change anything about default preferences, It is just about fixing the typos and documentation.

It'd be also cool if user could choose between starship and p10k during installation (not sure if it is implemented)

@kRHYME7 kRHYME7 merged commit 82de0f7 into HyDE-Project:dev Jun 1, 2025
@github-actions github-actions bot mentioned this pull request Jun 1, 2025
Merged
@rasputyashka rasputyashka deleted the issue-708 branch June 1, 2025 13:14
This was referenced Jun 1, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kRHYME7 added a commit that referenced this pull request Jun 6, 2025
@kRHYME7
chore: release automated changes from dev to master (#702)
6b08d79 
This is an automated PR to promote changes from `dev` to `master`.
Please review and test before merging.


See [TESTING.md](./TESTING.md) for complete testing instructions.


According to our release policy, this PR is expected to be merged on:
**Friday**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* fix(hyprlock) : minor fix (b7566f0) by kRHYME7
* chore Merge branch 'master' into dev (c461d04) by Khing
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (c8a9501) by kRHYME7
* chore ✨ (4528ca7) by kRHYME7
* chore Merge branch 'master' into dev (a9b3518) by Khing
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (374c640) by kRHYME7
* chore start hyprsunset via statefile (2366622) by kRHYME7
* fix: set resonable waybar tray spacing (#744) (a4243be) by Ilya
Bogdanov
* chore refactor: Hyprsunset (4ab1c9f) by kRHYME7
* fix: #739 (27b5da3) by kRHYME7
* feat: add hyde-menu module to all hyprdots-ported layouts (#740)
(04eef1d) by Ilya Bogdanov
* fix(zsh): Syntax error (d3ba6a1) by kRHYME7
* fix: make waybar ignore example layouts (#742) (6146a46) by Ilya
Bogdanov
* chore refactor: waybar.py considers font & icon values from
config.toml (#743) (12d8c1c) by Ilya Bogdanov
* fix(waybar): revert example as being used by users (1e63e69) by
kRHYME7
* fix: Do not use active first for taskbar (6f9fdd5) by kRHYME7
* fix(waybar): Fixes updates module (6098938) by kRHYME7
* feat(waybar): added `waybar.scale` to change waybar font-size
(0219627) by kRHYME7
* chore Update Configs/.config/hypr/windowrules.conf (52ce1c1) by Khing
* feat: adding some bottom bars (ace7c6b) by kRHYME7
* chore breaking: Waybar Restructured. (fe1b15e) by Khing
* fix: no reboot option after installation (#721) (d4aefe7) by amit
* chore config: fixed windowrule regex that matches unintended windows
(#724) (ded4f96) by denisu14
* fix: mediaplayer.py `artist_track_separator` refers to undefined var
(#723) (afc3312) by Ilya Bogdanov
* feat: disable gtk window control buttons by default (#722) (7b55b0e)
by Ilya Bogdanov
* fixed version (#718) (c86f16a) by Konstantin Rasputin
* chore Feat : Query before showing image in fastfetch (2b295eb) by
kRHYME7
* fix: migrate window rules to new syntax (#697) (6f78180) by Ilya
Bogdanov
* feat: customizable separator for mediaplayer.py (#710) (f988ae9) by
Ilya Bogdanov
* docs: To disable command not found handler for zshrc! (7d435f8) by
kRHYME7
* chore Merge branch 'master' into dev (fd25938) by Khing
* fix: fix issue 713 (#714) (314cf20) by Konstantin Rasputin
* fix: fix issue 708: typos in starship config (#712) (82de0f7) by
Konstantin Rasputin
* feat: add keybinding for hyprlock layout select menu (#699) (66406cd)
by Rubin Bhandari
* chore Merge branch 'dev' into hyprlock-keybinding (2b29001) by Rubin
Bhandari
* fix: mediaplayer conditions now work properly (#706) (c16544b) by
Ilya Bogdanov
* chore Merge branch 'dev' into hyprlock-keybinding (52e15eb) by Rubin
Bhandari
* fix: pasting (7eb1208) by kRHYME7
---

Please review the changes carefully before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rasputyashka @kRHYME7