Improve dry-run consistency and avoid unintended modifications #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig changes - Prevent real system modifications when dry-run mode is active (e.g., bootloader entries). - Ensure 'skip' options (like grub theme) do not alter current configuration. - Omitted 'sed' lines that unnecessarily modified out existing GRUB_THEME values. - Unified dry-run checks across the script for consistency and predictability. - Style: Improved readability by changing contrasts and minor settings. Ensures the script behaves as intended during dry-run
Contributor
|
Thanks! Have you tested this on fresh installation? |
Contributor
|
@HyDE-Project/testers Thank you in advance |
Member
|
looks nice!! i'll test it out in the morning |
Contributor
Author
Hi, sorry for the delay, and yes, I tested it on a fresh installation, so please review all the code before doing so.
Thank you, I hope it helps the project :) |
Member
|
Sorry, a bunch of last minute stuff popped up! LGTM! Everything worked fine 👍 |
Contributor
|
Hmm should I merge it now? Any changes you need to do @RanMd ? |
zeerayne
reviewed
Jun 9, 2025
Contributor
Author
Hello bro, of course I already solved the previous review, I would think so. |
kRHYME7
approved these changes
Jun 10, 2025
Contributor
kRHYME7
left a comment
kRHYME7
left a comment
There was a problem hiding this comment.
Works as expected! Thank you
Contributor
Author
|
Nice bro, glad I could help. |
kRHYME7
added a commit
that referenced
this pull request
Jun 13, 2025
This is an automated PR to promote changes from `dev` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **Friday** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (cb99278) by kRHYME7 * fix: [Bug]: Executing `resetxdgportal.sh` on startup may conflict with systemd services #727 (83ab1b9) by kRHYME7 * chore Merge branch 'master' into dev (5db92ed) by Khing * chore refactor: hyprlock avoid multiple process (mem leak on hyprlock?) (c50422e) by kRHYME7 * fix: Rofi launch args should accept array (581ddc7) by kRHYME7 * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (885d9a8) by kRHYME7 * feat: set Xresource and Xdefaultffor cursors too (c26bc0f) by kRHYME7 * fix: include nixos wrapped program to prevent infinite reloads (#795) (fda4f70) by Richard Henninger * chore update: use more flexible flags for electron-based apps (#790) (b05d1a7) by Ilya Bogdanov * feat(wl-clip-persist): Keep Wayland clipboard even after programs close (09c37dc) by kRHYME7 * doc: fix schema for the site (b6b8bf2) by kRHYME7 * fix : [Bug]: Executing `resetxdgportal.sh` on startup may conflict with systemd services #727 (20a30af) by kRHYME7 * chore Correctly handle -run-command in rofi for uwsm with fall back (018bfec) by kRHYME7 * chore update: hyprlock minor fixes (#791) (8dbd753) by Ilya Bogdanov * chore Fix: Question: Disable Rofi Launcher Menu History? #777 (0c7bec4) by kRHYME7 * feat: Schema validations plus default config and md for reference (91781d3) by kRHYME7 * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (7fa7e09) by kRHYME7 * chore Merge branch 'master' into dev (0d328ae) by Khing * chore Merge branch 'dev' of https://github.com/hyde-project/hyde into dev (10710e6) by kRHYME7 * feat: Handle services for user and root (a57bd1b) by kRHYME7 * chore Improve dry-run consistency and avoid unintended modifications (#762) (98338c0) by Alexander Luisa * chore Merge branch 'master' into dev (23c7418) by Khing * feat: port kanji & roman options of `hyprland/workspaces` waybar module (#776) (62425da) by Ilya Bogdanov * fix(gamelauncher): Use 5 as default MODE if not explicitly defined (2e740ee) by kRHYME7 --- Please review the changes carefully before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Key Changes
Ensures that
dry-runmode prevents any real changes to the system, including:sedreplacementsRemoves actions that previously ran even during dry-run, such as:
GRUB_THEMElinessedchanges to GRUB or loader entriesTreats
--skipoptions as true no-ops (e.g. skipping theme selection no longer modifies the config).Maintains logging and output for transparency
Type of change
Checklist
Please put an
xin the boxes that apply:Additional context
Why?
Some operations were still modifying files (e.g., GRUB theme config) even when dry-run mode was active. This goes against user expectations and makes testing riskier. This PR ensures that when dry-run is active, no changes are made—making it safe and predictable.
Notes