Skip to content

Conversation

@richen604
Copy link
Collaborator

Pull Request

Description

fixes infinite reload of the waybar python script because nixos is special and has special named programs 😅

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

image

Additional context

on a sidenote i have a sed script already that replaces killall waybar with .waybar-wrapped globally, weirdly pkill waybar somehow works

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 12, 2025

What happens if we use pkill? do we still need the waybar-wrap ?

@richen604
Copy link
Collaborator Author

nope pkill works directly with waybar, no idea why

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 12, 2025

Let's just use pkill then.

@richen604
Copy link
Collaborator Author

would you want something like that in a separate MR? I'm fine with this as is for now

looking into it pkill waybar would be the same as killall "*waybar*" and match all processes with waybar in the name. might not be ideal

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 12, 2025

I find .waybar-wrapped confusing as per non nix so i am trying to compensate in using pkill.

I think we can do exact matching for pkill

pkill -x waybar

should do the trick

@richen604
Copy link
Collaborator Author

if you were to do something explicit it would have to match both processes, eg killall -r "waybar|\.waybar-wrapped"
i try to get around this using sed because its kitty, dunst, and waybar that only have wrapped versions, so let me worry about that confusion in hydenix

ps -C waybar,.waybar-wrapped will match both processes, if this can be merged i have less sed commands to maintain

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 13, 2025

I'm still confused 😂 But ok 👌

@kRHYME7 kRHYME7 merged commit fda4f70 into HyDE-Project:dev Jun 13, 2025
2 checks passed
kRHYME7 added a commit that referenced this pull request Jun 13, 2025
This is an automated PR to promote changes from `dev` to `master`.
Please review and test before merging.


See [TESTING.md](./TESTING.md) for complete testing instructions.


According to our release policy, this PR is expected to be merged on:
**Friday**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (cb99278) by kRHYME7
* fix: [Bug]: Executing `resetxdgportal.sh` on startup may conflict with
systemd services #727 (83ab1b9) by kRHYME7
* chore Merge branch 'master' into dev (5db92ed) by Khing
* chore refactor: hyprlock avoid multiple process (mem leak on
hyprlock?) (c50422e) by kRHYME7
* fix: Rofi launch args should accept array (581ddc7) by kRHYME7
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (885d9a8) by kRHYME7
* feat: set Xresource and Xdefaultffor cursors too (c26bc0f) by kRHYME7
* fix: include nixos wrapped program to prevent infinite reloads (#795)
(fda4f70) by Richard Henninger
* chore update: use more flexible flags for electron-based apps (#790)
(b05d1a7) by Ilya Bogdanov
* feat(wl-clip-persist): Keep Wayland clipboard even after programs
close (09c37dc) by kRHYME7
* doc: fix schema for the site (b6b8bf2) by kRHYME7
* fix : [Bug]: Executing `resetxdgportal.sh` on startup may conflict
with systemd services #727 (20a30af) by kRHYME7
* chore Correctly handle -run-command in rofi for uwsm with fall back
(018bfec) by kRHYME7
* chore update: hyprlock minor fixes (#791) (8dbd753) by Ilya Bogdanov
* chore Fix: Question: Disable Rofi Launcher Menu History? #777
(0c7bec4) by kRHYME7
* feat: Schema validations plus default config and md for reference
(91781d3) by kRHYME7
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (7fa7e09) by kRHYME7
* chore Merge branch 'master' into dev (0d328ae) by Khing
* chore Merge branch 'dev' of https://github.com/hyde-project/hyde into
dev (10710e6) by kRHYME7
* feat: Handle services for user and root (a57bd1b) by kRHYME7
* chore Improve dry-run consistency and avoid unintended modifications
(#762) (98338c0) by Alexander Luisa
* chore Merge branch 'master' into dev (23c7418) by Khing
* feat: port kanji & roman options of `hyprland/workspaces` waybar
module (#776) (62425da) by Ilya Bogdanov
* fix(gamelauncher): Use 5 as default MODE if not explicitly defined
(2e740ee) by kRHYME7
---

Please review the changes carefully before merging.
@richen604 richen604 deleted the fix-waybar-nixos branch August 21, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants