Skip to content

feat(combo): Exported filter strategy for non-diacritic filter #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2023
Merged

feat(combo): Exported filter strategy for non-diacritic filter #13071

merged 7 commits into from
Jul 20, 2023

Conversation

rkaraivanov
Copy link
Member

@rkaraivanov rkaraivanov commented May 31, 2023 •
edited
Loading

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@rkaraivanov rkaraivanov requested a review from damyanpetev May 31, 2023 14:33
@rkaraivanov
Copy link
Member Author

@damyanpetev
I didn't add an entry to the changelog since I'm not 100% sure on the naming.
I'm open for suggestions.

@rkaraivanov rkaraivanov added the squash-merge Merge PR with "Squash and Merge" option label May 31, 2023
@rkaraivanov rkaraivanov requested a review from Lipata May 31, 2023 14:35
@Lipata Lipata requested a review from jackofdiamond5 June 1, 2023 08:50
Lipata
Lipata previously approved these changes Jun 1, 2023
View reviewed changes
@valadzhov valadzhov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 2, 2023
jackofdiamond5
jackofdiamond5 reviewed Jun 5, 2023
View reviewed changes
jackofdiamond5
jackofdiamond5 previously approved these changes Jun 5, 2023
View reviewed changes
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 5, 2023
@damyanpetev
Copy link
Member

@rkaraivanov Since this only add the filtering capability, I wouldn't really say it completes the referenced issue. Still need to look at options for sorting, right?

@rkaraivanov rkaraivanov dismissed stale reviews from jackofdiamond5 and Lipata via e05bd4f June 7, 2023 06:29
@ChronosSF ChronosSF changed the base branch from 16.0.x to master June 7, 2023 08:16
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jun 12, 2023
@kdinev kdinev changed the base branch from master to 16.0.x July 12, 2023 11:17
@ChronosSF ChronosSF mentioned this pull request Jul 19, 2023
Closed
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 20, 2023
@ChronosSF ChronosSF merged commit a61a3e7 into 16.0.x Jul 20, 2023
@ChronosSF ChronosSF deleted the rkaraivanov/feat-12876 branch July 20, 2023 08:26
ChronosSF pushed a commit that referenced this pull request Jul 20, 2023
@rkaraivanov @Lipata
@kdinev @ChronosSF
feat(combo): Exported filter strategy for non-diacritic filter (#13071)
b5fa2d8 
* feat(combo): Exported filter strategy for non-diacritic filter

Closes #12876

* refactor: Renamed export and added CHANGELOG entry

---------

Co-authored-by: Nikolay Alipiev <[email protected]>
Co-authored-by: Konstantin Dinev <[email protected]>
Lipata pushed a commit that referenced this pull request Jul 20, 2023
@ChronosSF
feat(combo): Exported filter strategy for non-diacritic filter (#13071)…
9d0437b 
… (#13298)
desig9stein pushed a commit that referenced this pull request Jul 26, 2023
@ChronosSF @desig9stein
feat(combo): Exported filter strategy for non-diacritic filter (#13071)…
dd3f70d 
… (#13298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@jackofdiamond5 jackofdiamond5 Awaiting requested review from jackofdiamond5

Assignees

@valadzhov valadzhov

Labels
combo simple-combo squash-merge Merge PR with "Squash and Merge" option version: 16.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rkaraivanov @damyanpetev @Lipata @jackofdiamond5 @kdinev @ChronosSF @valadzhov