[MOB-8515]: allow-popups-to-escape-sandbox #380
Conversation
src/inapp/utils.ts
Outdated
| @@ -284,9 +284,14 @@ const generateSecuredIFrame = () => { | |||
| iframe.setAttribute('id', 'iterable-iframe'); | |||
| // allow-popups and allow-top-navigation is to enable links for Safari since the iframe will block | |||
| // event handlers on elements in it preventing our custom link handling | |||
| console.log({ p: process.env }); | |||
There was a problem hiding this comment.
Should remove console log
@ts-nguyen Security is aware of this and will review this today. As for the README, I've alerted docs about this PR so will let them determine what changes are needed. |
| @@ -9,6 +9,8 @@ function getParsedEnv() { | |||
| ...env.parsed, | |||
| VERSION: version, | |||
| IS_EU_ITERABLE_SERVICE: process.env.IS_EU_ITERABLE_SERVICE || false, | |||
| DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION: | |||
| process.env.DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION || false | |||
There was a problem hiding this comment.
Should we do a strict check against true given the effect of the changes this value controls?
There was a problem hiding this comment.
this is the webpack config to allow the env variable to be passed in. made the check a const and made it stricter here
| @@ -8,3 +8,6 @@ | |||
|
|
|||
| # Convenience variable to automatically set the login email during testing. | |||
| # [email protected] | |||
|
|
|||
| # IS_EU_ITERABLE_SERVICE=false | |||
| # DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION=false | |||
There was a problem hiding this comment.
Why do we need this at the sample app level?
There was a problem hiding this comment.
When the package is installed via package manager, devs don't have access to modify the .env file of the web-sdk so they need to be able to pass this value in from their own .env. This just serves as an example of how to do that.
* Information about allow-popups-to-escape-sandbox * SDK version information * Update README.md * Update README.md --------- Co-authored-by: Mitch Prewitt <[email protected]>
JIRA Ticket(s) if any
Description
See https://googlechrome.github.io/samples/allow-popups-to-escape-sandbox/
Test Steps