-
Notifications
You must be signed in to change notification settings - Fork 9
[MOB-8515]: allow-popups-to-escape-sandbox #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
ae4f972
eb7fd83
94534dc
d14f66e
5742ee6
c3c1d2d
c0a5a9b
834010e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,6 @@ | |
|
||
# Convenience variable to automatically set the login email during testing. | ||
# [email protected] | ||
|
||
# IS_EU_ITERABLE_SERVICE=false | ||
# DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION=false | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,8 @@ function getParsedEnv() { | |
...env.parsed, | ||
VERSION: version, | ||
IS_EU_ITERABLE_SERVICE: process.env.IS_EU_ITERABLE_SERVICE || false, | ||
DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION: | ||
process.env.DANGEROUSLY_ALLOW_JS_POPUP_EXECUTION || false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we do a strict check against There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the webpack config to allow the env variable to be passed in. made the check a const and made it stricter here |
||
}; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this at the sample app level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the package is installed via package manager, devs don't have access to modify the
.env
file of the web-sdk so they need to be able to pass this value in from their own.env
. This just serves as an example of how to do that.