[MOB-11649] updated embedded message class #670

evantk91 · 2025-06-26T21:27:07Z

🔹 JIRA Ticket(s) if any

MOB-11649

✏️ Description

Please provide a brief description of what this pull request does.

…le-embedded-message-button-class

…d-message-button-class [MOB-11550] creates iterableEmbeddedMessageButton class

…le-embedded-message-button-class

…d-message-button-class [MOB-XXXX] adds labels for dict

…le-embedded-message-elements-class

…d-message-elements-class [MOB-11551] creates IterableEmbeddedMessageElements class

…e-embedded-message-class

…-message-class [MOB-7936] creates IterableEmbeddedMessage class

github-actions · 2025-06-26T21:27:44Z

Lines	Statements	Branches	Functions
	41.24% (205/497)	18.65% (36/193)	34.16% (55/161)

codeclimate · 2025-06-26T21:29:22Z

❌ 6 blocking issues (7 total)

Tool	Category	Rule	Count
eslint	Lint	Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
6	❌
qlty	Structure	Function with high complexity (count = 8): constructor	1

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

codeclimate · 2025-06-26T21:29:23Z

src/__tests__/IterableEmbeddedMessageElementsButton.test.ts

@@ -1,5 +1,4 @@
 import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-26T21:29:24Z

src/embedded/classes/IterableEmbeddedMessageElements.ts

-    const buttons = dict.buttons?.map((button) =>
-      IterableEmbeddedMessageElementsButton.fromDict(button)
+    const buttons = dict.buttons?.map(
+      (button) => new IterableEmbeddedMessageElementsButton(button)
    );

    const text = dict.text?.map((text) =>


'text' is already declared in the upper scope on line 74 column 11. [eslint:@typescript-eslint/no-shadow]

codeclimate · 2025-06-26T21:29:24Z

src/embedded/classes/IterableEmbeddedMessageElementsButton.ts

@@ -1,5 +1,3 @@
-import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction';
-
 /**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-26T21:56:37Z

src/embedded/classes/IterableEmbeddedMessageElements.ts

-    const text = dict.text?.map((text) =>
-      IterableEmbeddedMessageText.fromDict(text)
+    const text = dict.text?.map(
+      (text) => new IterableEmbeddedMessageText(text)


'text' is already declared in the upper scope on line 74 column 11. [eslint:@typescript-eslint/no-shadow]

codeclimate · 2025-06-26T22:50:51Z

src/__tests__/IterableEmbeddedMessageMetadata.test.ts

@@ -52,7 +52,8 @@ describe('IterableEmbeddedMessage', () => {
    };

    expect(() => {
-      IterableEmbeddedMessageMetadata.fromDict(dict);
+      // @ts-expect-error - messageId is purposely missing
+      new IterableEmbeddedMessageMetadata(dict);


Do not use 'new' for side effects. [eslint:no-new]

codeclimate · 2025-06-27T16:19:14Z

src/__tests__/IterableEmbeddedMessageButton.test.ts

@@ -0,0 +1,86 @@
+import { IterableEmbeddedMessageButton } from '../embedded/classes/IterableEmbeddedMessageButton';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:19:14Z

src/embedded/classes/IterableEmbeddedMessage.ts

@@ -0,0 +1,131 @@
+import { IterableEmbeddedMessageButton } from './IterableEmbeddedMessageButton';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:19:15Z

src/embedded/classes/IterableEmbeddedMessage.ts

+  constructor(dict: EmbeddedMessageDict) {
+    if (!dict.metadata) {
+      throw new Error('metadata is required');
+    }
+    this.metadata = {
+      messageId: dict.metadata.messageId,
+      placementId: dict.metadata.placementId,
+      campaignId: dict.metadata.campaignId,
+      isProof: dict.metadata.isProof,
+    };
+
+    if (dict.elements) {
+      this.elements = {
+        title: dict.elements?.title,
+        body: dict.elements?.body,
+        mediaUrl: dict.elements?.mediaUrl,
+        mediaUrlCaption: dict.elements?.mediaUrlCaption,
+      };
+
+      if (dict.elements?.defaultAction) {
+        this.elements.defaultAction = {
+          type: dict.elements.defaultAction.type,
+          data: dict.elements.defaultAction.data,
+        };
+      }
+
+      if (dict.elements?.buttons) {
+        this.elements.buttons = dict.elements.buttons.map(
+          (button) => new IterableEmbeddedMessageButton(button)
+        );
+      }
+
+      if (dict.elements?.text) {
+        this.elements.text = dict.elements.text.map(
+          (text) => new IterableEmbeddedMessageText(text)
+        );
+      }
+    }
+
+    this.payload = dict.payload;


Function with high complexity (count = 8): constructor [qlty:function-complexity]

codeclimate · 2025-06-27T16:19:15Z

src/embedded/classes/IterableEmbeddedMessageButton.ts

@@ -0,0 +1,54 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:14Z

src/__tests__/IterableEmbeddedMessage.test.ts

@@ -0,0 +1,162 @@
+import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:14Z

src/__tests__/IterableEmbeddedMessageButton.test.ts

@@ -0,0 +1,86 @@
+import { IterableEmbeddedMessageButton } from '../embedded/classes/IterableEmbeddedMessageButton';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:14Z

src/__tests__/IterableEmbeddedMessageText.test.ts

@@ -0,0 +1,39 @@
+import { IterableEmbeddedMessageText } from '../embedded/classes/IterableEmbeddedMessageText';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:14Z

src/embedded/classes/IterableEmbeddedMessage.ts

@@ -0,0 +1,131 @@
+import { IterableEmbeddedMessageButton } from './IterableEmbeddedMessageButton';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:14Z

src/embedded/classes/IterableEmbeddedMessage.ts

+  constructor(dict: EmbeddedMessageDict) {
+    if (!dict.metadata) {
+      throw new Error('metadata is required');
+    }
+    this.metadata = {
+      messageId: dict.metadata.messageId,
+      placementId: dict.metadata.placementId,
+      campaignId: dict.metadata.campaignId,
+      isProof: dict.metadata.isProof,
+    };
+
+    if (dict.elements) {
+      this.elements = {
+        title: dict.elements?.title,
+        body: dict.elements?.body,
+        mediaUrl: dict.elements?.mediaUrl,
+        mediaUrlCaption: dict.elements?.mediaUrlCaption,
+      };
+
+      if (dict.elements?.defaultAction) {
+        this.elements.defaultAction = {
+          type: dict.elements.defaultAction.type,
+          data: dict.elements.defaultAction.data,
+        };
+      }
+
+      if (dict.elements?.buttons) {
+        this.elements.buttons = dict.elements.buttons.map(
+          (button) => new IterableEmbeddedMessageButton(button)
+        );
+      }
+
+      if (dict.elements?.text) {
+        this.elements.text = dict.elements.text.map(
+          (text) => new IterableEmbeddedMessageText(text)
+        );
+      }
+    }
+
+    this.payload = dict.payload;


Function with high complexity (count = 8): constructor [qlty:function-complexity]

codeclimate · 2025-06-27T16:20:14Z

src/embedded/classes/IterableEmbeddedMessageButton.ts

@@ -0,0 +1,54 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-27T16:20:15Z

src/embedded/classes/IterableEmbeddedMessageText.ts

@@ -0,0 +1,40 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

Evan Greer and others added 17 commits June 9, 2025 11:30

feat: adds button class and associated classes

1c56ff1

feat: adds unit tests

4578c01

feat: adds elements class and associated classes

57f48a3

feat: adds unit tests

a3397a4

feat: adds message class and unit tests

79e7225

Merge branch 'evan/embedded-message-class' into evan/MOB-11550-iterab…

27af816

…le-embedded-message-button-class

Merge pull request #655 from Iterable/evan/MOB-11550-iterable-embedde…

12ac9b6

…d-message-button-class [MOB-11550] creates iterableEmbeddedMessageButton class

feat: adds labels for dict

80d7981

Merge branch 'evan/embedded-message-class' into evan/MOB-11550-iterab…

aa2be62

…le-embedded-message-button-class

Merge pull request #667 from Iterable/evan/MOB-11550-iterable-embedde…

d6b0a0a

…d-message-button-class [MOB-XXXX] adds labels for dict

Merge branch 'evan/embedded-message-class' into evan/MOB-11551-iterab…

a292556

…le-embedded-message-elements-class

chore: adds comments to props

58fe64e

Merge pull request #656 from Iterable/evan/MOB-11551-iterable-embedde…

2b2899c

…d-message-elements-class [MOB-11551] creates IterableEmbeddedMessageElements class

Merge branch 'evan/embedded-message-class' into evan/MOB-7936-iterabl…

3a486d6

…e-embedded-message-class

chore: adds comments to props

84e6a68

Merge pull request #657 from Iterable/evan/MOB-7936-iterable-embedded…

8df97eb

…-message-class [MOB-7936] creates IterableEmbeddedMessage class

feat: merges action into button

cad9c3e

evantk91 changed the base branch from evan/feature/embedded to evan/embedded-message-class June 26, 2025 21:27

evantk91 changed the title ~~[MOB-11649]~~ [MOB-11649] Convert subclasses of message into interfaces Jun 26, 2025

evantk91 marked this pull request as draft June 26, 2025 21:28

codeclimate bot reviewed Jun 26, 2025

View reviewed changes

feat: updates IterableEmbeddedMessageText class

5f51526

codeclimate bot reviewed Jun 26, 2025

View reviewed changes

Evan Greer added 5 commits June 26, 2025 16:15

feat: converts IterableEmbeddedMessageElements constructor

7c2c8aa

feat: removes default action class

3c0e01d

feat: converts IterableEmbeddedMessage constructor

56b33b0

feat: converts IterableEmbeddedMessage constructor

1db3333

feat: removes embedded metadata class

2b627f3

codeclimate bot reviewed Jun 26, 2025

View reviewed changes

feat: combines message and elements in one class

6701a64

evantk91 changed the base branch from evan/embedded-message-class to evan/feature/embedded June 27, 2025 16:17

codeclimate bot reviewed Jun 27, 2025

View reviewed changes

evantk91 marked this pull request as ready for review June 27, 2025 16:27

evantk91 changed the title ~~[MOB-11649] Convert subclasses of message into interfaces~~ [MOB-11649] embedded message class Jun 27, 2025

evantk91 changed the title ~~[MOB-11649] embedded message class~~ [MOB-11649] updated embedded message class Jun 27, 2025

		@@ -1,5 +1,4 @@
		import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton';

		@@ -1,5 +1,3 @@
		import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction';

		/**

		@@ -0,0 +1,86 @@
		import { IterableEmbeddedMessageButton } from '../embedded/classes/IterableEmbeddedMessageButton';

		@@ -0,0 +1,131 @@
		import { IterableEmbeddedMessageButton } from './IterableEmbeddedMessageButton';

		@@ -0,0 +1,162 @@
		import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';

		@@ -0,0 +1,39 @@
		import { IterableEmbeddedMessageText } from '../embedded/classes/IterableEmbeddedMessageText';

[MOB-11649] updated embedded message class #670

Are you sure you want to change the base?

[MOB-11649] updated embedded message class #670

Uh oh!

Conversation

evantk91 commented Jun 26, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

github-actions bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeclimate bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 6 blocking issues (7 total)

Uh oh!

codeclimate bot Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evantk91 commented Jun 26, 2025 •

edited by jira bot

Loading

github-actions bot commented Jun 26, 2025 •

edited

Loading

codeclimate bot commented Jun 26, 2025 •

edited

Loading