Skip to content

Allow ForwardDiff v1#1957

Merged
devmotion merged 3 commits into
JuliaStats:masterfrom
mcabbott:patch-1
Mar 28, 2025
Merged

Allow ForwardDiff v1#1957
devmotion merged 3 commits into
JuliaStats:masterfrom
mcabbott:patch-1

Conversation

@mcabbott

Copy link
Copy Markdown
Contributor

Not sure why CompatHelper didn't make a PR for this.

@codecov-commenter

codecov-commenter commented Mar 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (b348b5b) to head (8a0fcef).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1957   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         146      146           
  Lines        8769     8769           
=======================================
  Hits         7559     7559           
  Misses       1210     1210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion

Copy link
Copy Markdown
Member

The test errors look real.

@sethaxen

Copy link
Copy Markdown
Contributor

Not sure why CompatHelper didn't make a PR for this.

It still doesn't make PRs for dependencies only in [extras]

@devmotion

Copy link
Copy Markdown
Member

Which is annoying for CI but at least irrelevant for all downstream packages as the compat entries of [extras] dependencies are not respected when Distributions is used as a dependency somewhere.

Comment thread Project.toml Outdated
uuid = "31c24e10-a181-5473-b8eb-7969acd0382f"
authors = ["JuliaStats"]
version = "0.25.118"
version = "0.25.119"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR doesn't change the package, pnly the tests, so we don't need a new release:

Suggested change
version = "0.25.119"
version = "0.25.118"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this because add ForwardDiff@1 leads to "ERROR: Unsatisfiable requirements detected for package Distributions [31c24e10]:", which involved LsqFit... but you may be right that it's not what's bounding ForwardDiff, not really sure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you encounter it when trying to update a downstream package?

@devmotion devmotion merged commit 05a7875 into JuliaStats:master Mar 28, 2025
@mcabbott mcabbott deleted the patch-1 branch March 28, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants