Skip to content

Allow ForwardDiff v1 #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 3 commits into from
Mar 28, 2025
+5 −3
Merged

Allow ForwardDiff v1 #1957

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f995896
Allow ForwardDiff v1
mcabbott Mar 28, 2025
619ad45
Update tests
devmotion Mar 28, 2025
8a0fcef
Don't update version number
devmotion Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Distributions"
uuid = "31c24e10-a181-5473-b8eb-7969acd0382f"
authors = ["JuliaStats"]
version = "0.25.118"
version = "0.25.119"

@devmotion devmotion Mar 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR doesn't change the package, pnly the tests, so we don't need a new release:

Suggested change
version = "0.25.119"
version = "0.25.118"

@mcabbott mcabbott Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this because add ForwardDiff@1 leads to "ERROR: Unsatisfiable requirements detected for package Distributions [31c24e10]:", which involved LsqFit... but you may be right that it's not what's bounding ForwardDiff, not really sure.

@devmotion devmotion Mar 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you encounter it when trying to update a downstream package?


[deps]
AliasTables = "66dad0bd-aa9a-41b7-9441-69ab47430ed8"
Expand Down Expand Up @@ -40,7 +40,7 @@ DensityInterface = "0.4"
Distributed = "<0.0.1, 1"
FillArrays = "0.9, 0.10, 0.11, 0.12, 0.13, 1"
FiniteDifferences = "0.12"
ForwardDiff = "0.10"
ForwardDiff = "0.10, 1"
JSON = "0.21"
LinearAlgebra = "<0.0.1, 1"
OffsetArrays = "1"
Expand Down
6 changes: 4 additions & 2 deletions test/univariate/discrete/negativebinomial.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,10 @@ end

@testset "issue #1582" begin
dp = mydiffp(1.0, 1.0, 0.0)
@test ForwardDiff.derivative(p -> logpdf(NegativeBinomial(1.0, p), 0.0), 1.0) == dp == 1.0
@test dp == 1
@test ForwardDiff.derivative(p -> logpdf(NegativeBinomial(1.0, p; check_args=false), 0.0), 1.0) == dp

dr = mydiffr(1.0, 1.0, 0.0)
@test ForwardDiff.derivative(r -> logpdf(NegativeBinomial(r, 1.0), 0.0), 1.0) == dr == 0.0
@test dr == 0
@test ForwardDiff.derivative(r -> logpdf(NegativeBinomial(r, 1.0), 0.0), 1.0) == dr
end