Add shorthand for &self in RustQt blocks where the type can be inferred #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 75 +2
Lines 12681 12772 +91
=========================================
+ Hits 12681 12772 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
4 times, most recently
from
32371fd to
e457080
Compare
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
2 times, most recently
from
b97d362 to
8d63f02
Compare
|
Tried to implement in the qml_features example and there is a cxx error about there being multiple types in the block, even though there is only one qobject in the example, which may be because it adds the QObject import? |
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
from
84e9300 to
c05d75d
Compare
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
2 times, most recently
from
128b0f4 to
698c4d7
Compare
ahayzen-kdab
reviewed
Apr 8, 2025
ahayzen-kdab
reviewed
Apr 8, 2025
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
3 times, most recently
from
85d8ee3 to
edc96d6
Compare
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
2 times, most recently
from
f7c81e2 to
a654673
Compare
LeonMatthesKDAB
requested changes
May 20, 2025
There was a problem hiding this comment.
Hi @BenFordTytherington, I'm very happy to see this work.
There are however some changes I want to see before we merge this. Especially I think it would be better to use an Array of Structures instead of a Structure of Arrays.
Other than that it's just some minor nitpicks left.
…here the type can be inferred - If exactly one QObject is present in a block with a method, it will infer `Self` to represent that qobject - Updates one of the examples to test this out
- QObjects, and invokables are now 2D Vecs, kept in their original block - Adds some helper methods for iterating like they are still flat
- Add function call to cxx-qt-build and cxx-qt-macro - Inlining now happens after parsing and before structuring
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
5 times, most recently
from
74b93b5 to
1178075
Compare
- Refactor parsing steps to be more readable - Refactor tests to be better separated
BenFordTytherington
force-pushed
the
add-self-shorthand
branch
from
1178075 to
8618301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Pin<&mut Self>and&selfinside the bridge, as shorthand.&selfin bridge #1245