Add attribute which generates wrappers for a function #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 75 75
Lines 12927 13051 +124
==========================================
+ Hits 12927 13051 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
from
15fa262 to
c6de2c6
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
from
3620686 to
6bba256
Compare
ahayzen-kdab
reviewed
Sep 5, 2025
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
2 times, most recently
from
a6b282c to
4619a1b
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
2 times, most recently
from
bf40f52 to
b30fe57
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
from
b30fe57 to
4ed0a1f
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
4 times, most recently
from
72daf64 to
4ba0f8b
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
from
4ba0f8b to
f2d5b9b
Compare
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
4 times, most recently
from
899b1b1 to
e12132c
Compare
Collaborator
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Some nitpicks left, otherwise okay from my side.
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
3 times, most recently
from
904910f to
7b53406
Compare
ahayzen-kdab
previously approved these changes
Oct 1, 2025
Collaborator
ahayzen-kdab
left a comment
ahayzen-kdab
left a comment
There was a problem hiding this comment.
Looks good and a nice shorthand :-)
LeonMatthesKDAB
previously approved these changes
Oct 2, 2025
- Updates tests - Adds necessary import to impl block - Extract wrapper generation to function - Update book
BenFordTytherington
force-pushed
the
wrapper-shorthand
branch
from
9d109f0 to
8826137
Compare
ahayzen-kdab
approved these changes
Oct 3, 2025
Collaborator
ahayzen-kdab
left a comment
ahayzen-kdab
left a comment
There was a problem hiding this comment.
Looks good and the rebase sorted the commits chain out :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1235
Adds the
auto_wrapattribute which will generate the wrapper function for methods defined in the bridge.