Skip to content

Replace check_if_subscriber_in_array() function #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

n7studios
Copy link
Contributor

Summary

Replaces the check_if_subscriber_in_array() function, as we query the API by email_address - so inspecting the response’s total_subscribers is sufficient.

Testing

Existing tests pass

Checklist

This is no longer needed, as we query the API by `email_address`, so inspecting the response’s `total_subscribers` is sufficient.
@n7studios n7studios added this to the 1.0.0 milestone Mar 6, 2023
@n7studios n7studios self-assigned this Mar 6, 2023
@n7studios n7studios changed the base branch from fix-tests to fix-sort-order-tests March 6, 2023 16:57
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team March 6, 2023 17:04
@n7studios n7studios marked this pull request as ready for review March 6, 2023 17:04
@n7studios n7studios merged commit e00000c into fix-sort-order-tests Mar 7, 2023
@n7studios n7studios deleted the remove-subscriber-array-check-function branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants