Skip to content

Replace check_if_subscriber_in_array() function #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 5 additions & 29 deletions src/ConvertKit_API.php
Original file line number Diff line number Diff line change
Expand Up @@ -438,15 +438,13 @@ public function get_subscriber_id(string $email_address)
return false;
}

$subscriber_id = $this::check_if_subscriber_in_array($email_address, $subscribers->subscribers);

if ($subscriber_id) {
return $subscriber_id;
if ($subscribers->total_subscribers === 0) {
$this->create_log('No subscribers');
return false;
}

$this->create_log('Subscriber not found');

return false;
// Return the subscriber's ID.
return $subscribers->subscribers[0]->id;
}


Expand Down Expand Up @@ -761,26 +759,4 @@ public function make_request(string $endpoint, string $method, array $args = [])
$this->create_log('Failed to finish request.');
return false;
}


/**
* Looks for subscriber with email in array
*
* @param string $email_address Email Address.
* @param array $subscribers Subscribers.
*
* @return false|integer false if not found, else subscriber object
*/
private function check_if_subscriber_in_array(string $email_address, array $subscribers)
{
foreach ($subscribers as $subscriber) {
if ($subscriber->email_address === $email_address) {
$this->create_log('Subscriber found!');
return $subscriber->id;
}
}

$this->create_log('Subscriber not found on current page.');
return false;
}
}