[PLT-1993] Fixed relationship label bug #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabefire
force-pushed
the
gu/fix_annotations
branch
from
9e321da to
a7e2eb7
Compare
Gabefire
commented
Nov 22, 2024
| @@ -0,0 +1,217 @@ | |||
| import datetime | |||
There was a problem hiding this comment.
Relationships work different then other relationship so need a dedicated integration test
Gabefire
commented
Nov 22, 2024
| @@ -60,143 +60,19 @@ | |||
| class NDLabel(BaseModel): | |||
| annotations: AnnotationType | |||
|
|
|||
| class _Relationship(BaseModel): | |||
There was a problem hiding this comment.
This stuff was used when we use to deserialized so not needed anymore also is very complicated
…hon into gu/fix_annotations
Gabefire
commented
Nov 22, 2024
| ) | ||
|
|
||
|
|
||
| def test_relationship(): | ||
| with open("tests/data/assets/ndjson/relationship_import.json", "r") as file: |
There was a problem hiding this comment.
Simplified this test into two
Gabefire
commented
Nov 22, 2024
| @@ -233,19 +230,13 @@ def test_create_from_label_objects( | |||
| ), | |||
| ObjectAnnotation( | |||
| name="bbox", | |||
| extra={ | |||
There was a problem hiding this comment.
This could be breaking but want a second opinion. The extra field breaks the annotation if a customer decides to add it. It is not shown that they need to do this in the docs, and I don't see why they would. The old complicated logic removed these but to simplify this I think it is best to just not support this type of extra key
adrian-chang
approved these changes
Nov 22, 2024
Gabefire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features