-
Notifications
You must be signed in to change notification settings - Fork 67
[PLT-1993] Fixed relationship label bug #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c73472e
8bb20aa
9e321da
f2bdede
5d3b679
a7e2eb7
0d90916
af7b474
305ed67
c81501c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -218,9 +218,6 @@ def test_create_from_label_objects( | |
annotations=[ | ||
ObjectAnnotation( | ||
name="polygon", | ||
extra={ | ||
"uuid": "6d10fa30-3ea0-4e6c-bbb1-63f5c29fe3e4", | ||
}, | ||
value=Polygon( | ||
points=[ | ||
Point(x=147.692, y=118.154), | ||
|
@@ -233,19 +230,13 @@ def test_create_from_label_objects( | |
), | ||
ObjectAnnotation( | ||
name="bbox", | ||
extra={ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be breaking but want a second opinion. The extra field breaks the annotation if a customer decides to add it. It is not shown that they need to do this in the docs, and I don't see why they would. The old complicated logic removed these but to simplify this I think it is best to just not support this type of extra key |
||
"uuid": "15b7138f-4bbc-42c5-ae79-45d87b0a3b2a", | ||
}, | ||
value=Rectangle( | ||
start=Point(x=58.0, y=48.0), | ||
end=Point(x=70.0, y=113.0), | ||
), | ||
), | ||
ObjectAnnotation( | ||
name="polyline", | ||
extra={ | ||
"uuid": "cf4c6df9-c39c-4fbc-9541-470f6622978a", | ||
}, | ||
value=Line( | ||
points=[ | ||
Point(x=147.692, y=118.154), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stuff was used when we use to deserialized so not needed anymore also is very complicated