Repository navigation
feat: publish @lntt/lntt with the other @lntt packages, so a project installs lntt - #146
Merged
Merged
Conversation
|
This pull request now targets A hotfix stays on |
ilmeskio
force-pushed
the
feat/138/publish-lntt-lntt-other
branch
from
October 21, 2026 01:22
248175b to
8c73a18
Compare
…installs lntt @lntt/lntt is no longer private: it carries the release version, so packages-version.mts checks it and release.yml publishes it. The repo keeps running lntt from its sources through the workspace link; the published manifest points bin and exports at dist/ through publishConfig, which pnpm applies when it packs, so the release packs each package with pnpm and npm publishes the tarball. The build emits bin/ and src/ with declarations and copies agents/ next to them; schema/ ships at the top level for a project's $schema. @commitlint/config-conventional is a peer, the tool the package configures. A test packs the package, installs it into a real node_modules and runs the bin from there; lntt --help prints the usage and exits 0. Closes #138
@commitlint/config-conventional is an optional peer: only commitlintConfig names it, so lntt alone and npx @lntt/lntt --help install nothing more. -h and help are tested with --help. The installed-bin test requires dist/agents and the operator schema in the tarball, imports the ci entry and both schemas by name and compares their $id, shows a failing build's output and cleans its temporary directories. The ADR states that a pre-release publishes nothing and leaves the steps to the delivery process, which names the publishConfig fields npm ignores. Refs #138
…peer is optional The installed-bin test walks every bin and exports target of the packed manifest, types conditions included, and requires each one in the package; it requires the commitlint peer to stay optional, and runs the three help spellings from node_modules. Refs #138
ilmeskio
force-pushed
the
feat/138/publish-lntt-lntt-other
branch
from
October 21, 2026 12:01
8c73a18 to
ccb63ad
Compare
ilmeskio
marked this pull request as ready for review
October 21, 2026 12:01
Merged
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@lntt/lnttis no longer private. It carries the release version (0.6.1), soscripts/packages-version.mtschecks it with the other packages andrelease.ymlpublishes it. A project installs it withpnpm add -D @lntt/lntt, and thelnttcommand then runs fromnode_modules.dist/. Inpackages/lntt/package.json,binandexportsstay on the.tssources, so the workspace link keeps working unbuilt:pnpm exec lntt, the hooks,commitlint.config.mjsandcandidate.yml. The published manifest takes itsbinandexportsfrompublishConfig, which point atdist/. Only pnpm applies those overrides, sorelease.ymlpacks each package withpnpm packand npm publishes the tarball (with--provenance, through OIDC). For@lntt/create,pnpm packandnpm packproduce the same file list (157 files, compared).tsconfig.build.json, run byprepack) emitsbin/andsrc/todist/with declarations, then copiesagents/todist/agents, because the code reads../agentsrelative to its own module.filesshipsdistandschema, so a project's$schemacan point atnode_modules/@lntt/lntt/schema/config.schema.json.@commitlint/config-conventionalis an optional peer: the project installs the tool the package configures, as decided on the issue. It is optional because onlycommitlintConfignames it, solnttalone andnpx @lntt/lntt --helpneed nothing more.lntt --help,-handhelpprint the usage on stdout and exit 0. Before this change they exited 2.packages/lntt/test/installed-bin.test.tspacks the package with pnpm and extracts the tarball into a realnode_modules/@lntt/lntt. It runs the bin from there (the three help spellings,get, andsync, which readsdist/agents), and imports@lntt/lntt,@lntt/lntt/ciand both schemas by name. It also checks that everybinandexportstarget of the packed manifest is in the package, that each export has itstypescondition, and that the peer is optional.adoptentry for@lntt/lntt. It runslntt --helpandlntt get lunette.templatein the generated project.cli-runtime-and-publishing(ADR) gets the publishConfig rule and two discarded directions.delivery.mddescribes the pnpm-pack release and the placeholder for this package. The@lntt/lnttREADME now covers installation, and the root README lists the package.Definition of done
@lntt/lnttbuilt todist/, not private, at the release version, checked bypackages-version.mts.node scripts/packages-version.mts checkreports "7 packages at 0.6.1", andlistincludespackages/lntt.dependencies, and no devDependency is imported at run time (deduced from the bare imports insrc/andbin/, and confirmed by an install from the tarball with npm and with pnpm).@commitlint/config-conventionalis an optional peer.node --test test/installed-bin.test.tsinpackages/lnttgives 10 pass, 0 fail. Mutations caught by hand: noagents/copy, nopublishConfig(all fail), a wrong./citypes path,optional: false.@lntt/lntt: a person does this on npm.npm view @lntt/lnttgives E404 today. The steps are indocs/process/delivery.md, under "A new package", run frompackages/lnttright before tagging v0.6.2. A trusted-publisher configuration expires after two days unused. The coordinator has put this to the person.npx @lntt/lntt --helpworks in an empty folder. That needs the release. The publish loop was simulated locally:pnpm packandnpm publish <tarball> --dry-runfor all 7 packages at 0.6.2-rc.0, all passed.npx --yes --package=<tarball> lntt --helpexits 0 in an empty directory. Provenance from a tarball under OIDC is deduced from fix: provenance-file takes precedence over OIDC auto-generated provenance npm/cli#9947, not run.lntt check: 7 PASS, 0 FAIL.pnpm lint,pnpm typecheck: passed.pnpm --filter @lntt/lntt test: all pass.SCAFFOLD_SMOKE=1smoke inpackages/create: 2 pass, 0 fail (run on the first commit).pnpm ci:local --base candidate/5on ccb63ad (rebased oncandidate/5after ci: run the scaffold tests on the full CI, and on a candidate pull request only when it touches packages/create #151, which keeps the scaffold test's grep out of.git): 1 passed, 0 failed.lntt review, 3 rounds, the cap: 1.06M, 539k and 261k tokens, USD 1.17, 0.56 and 0.33 (2.06 in total).-handhelp, dry-run steps moved from the ADR todelivery.md.lntt check tests mutatereported "no test runs this line" because it does not mappackage.jsonto the test that packs it.typescondition per export) is fixed in 8c73a18, not reviewed again.delivery.md:195, "every release is a patch (0.6.N)", writes the minor into the text, and the lens proposes0.Y.N. That line predates this branch (00f946b). It is policy wording: if every release is a patch until 1.0.0, the minor stays 6.$schemaconvention named inagent-layer.md; the MIT license named in the ADR; the reason npm ignorespublishConfigstated in both the ADR anddelivery.md;nulland wildcard export targets in the test helper; the./ciimport checks that the entry loads, not what it does; no recorded decision for the help spellings.Closes #138
🤖 Generated with Claude Code