Skip to content

feat: publish @lntt/lntt with the other @lntt packages, so a project installs lntt - #146

Merged
ilmeskio merged 4 commits into
candidate/5from
feat/138/publish-lntt-lntt-other
Oct 21, 2026
Merged

ilmeskio merged 4 commits into
candidate/5from
feat/138/publish-lntt-lntt-other

Conversation

@ilmeskio

@ilmeskio ilmeskio commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What

@lntt/lntt is no longer private. It carries the release version (0.6.1), so scripts/packages-version.mts checks it with the other packages and release.yml publishes it. A project installs it with pnpm add -D @lntt/lntt, and the lntt command then runs from node_modules.

  • The repo runs the sources, the published package runs dist/. In packages/lntt/package.json, bin and exports stay on the .ts sources, so the workspace link keeps working unbuilt: pnpm exec lntt, the hooks, commitlint.config.mjs and candidate.yml. The published manifest takes its bin and exports from publishConfig, which point at dist/. Only pnpm applies those overrides, so release.yml packs each package with pnpm pack and npm publishes the tarball (with --provenance, through OIDC). For @lntt/create, pnpm pack and npm pack produce the same file list (157 files, compared).
  • The build (tsconfig.build.json, run by prepack) emits bin/ and src/ to dist/ with declarations, then copies agents/ to dist/agents, because the code reads ../agents relative to its own module. files ships dist and schema, so a project's $schema can point at node_modules/@lntt/lntt/schema/config.schema.json.
  • @commitlint/config-conventional is an optional peer: the project installs the tool the package configures, as decided on the issue. It is optional because only commitlintConfig names it, so lntt alone and npx @lntt/lntt --help need nothing more.
  • lntt --help, -h and help print the usage on stdout and exit 0. Before this change they exited 2.
  • packages/lntt/test/installed-bin.test.ts packs the package with pnpm and extracts the tarball into a real node_modules/@lntt/lntt. It runs the bin from there (the three help spellings, get, and sync, which reads dist/agents), and imports @lntt/lntt, @lntt/lntt/ci and both schemas by name. It also checks that every bin and exports target of the packed manifest is in the package, that each export has its types condition, and that the peer is optional.
  • The scaffold smoke has an adopt entry for @lntt/lntt. It runs lntt --help and lntt get lunette.template in the generated project.
  • Docs: cli-runtime-and-publishing (ADR) gets the publishConfig rule and two discarded directions. delivery.md describes the pnpm-pack release and the placeholder for this package. The @lntt/lntt README now covers installation, and the root README lists the package.

Definition of done

  • @lntt/lntt built to dist/, not private, at the release version, checked by packages-version.mts. node scripts/packages-version.mts check reports "7 packages at 0.6.1", and list includes packages/lntt.
  • Its run-time dependencies decided and declared. The five packages it imports are in dependencies, and no devDependency is imported at run time (deduced from the bare imports in src/ and bin/, and confirmed by an install from the tarball with npm and with pnpm). @commitlint/config-conventional is an optional peer.
  • A test runs the bin installed from its tarball: node --test test/installed-bin.test.ts in packages/lntt gives 10 pass, 0 fail. Mutations caught by hand: no agents/ copy, no publishConfig (all fail), a wrong ./ci types path, optional: false.
  • The placeholder published and trusted publishing configured for @lntt/lntt: a person does this on npm. npm view @lntt/lntt gives E404 today. The steps are in docs/process/delivery.md, under "A new package", run from packages/lntt right before tagging v0.6.2. A trusted-publisher configuration expires after two days unused. The coordinator has put this to the person.
  • The next release publishes it with provenance, and npx @lntt/lntt --help works in an empty folder. That needs the release. The publish loop was simulated locally: pnpm pack and npm publish <tarball> --dry-run for all 7 packages at 0.6.2-rc.0, all passed. npx --yes --package=<tarball> lntt --help exits 0 in an empty directory. Provenance from a tarball under OIDC is deduced from fix: provenance-file takes precedence over OIDC auto-generated provenance npm/cli#9947, not run.
  • lntt check: 7 PASS, 0 FAIL. pnpm lint, pnpm typecheck: passed. pnpm --filter @lntt/lntt test: all pass. SCAFFOLD_SMOKE=1 smoke in packages/create: 2 pass, 0 fail (run on the first commit).
  • pnpm ci:local --base candidate/5 on ccb63ad (rebased on candidate/5 after ci: run the scaffold tests on the full CI, and on a candidate pull request only when it touches packages/create #151, which keeps the scaffold test's grep out of .git): 1 passed, 0 failed.
  • lntt review, 3 rounds, the cap: 1.06M, 539k and 261k tokens, USD 1.17, 0.56 and 0.33 (2.06 in total).
    • Round 1: the peer made optional, tests for -h and help, dry-run steps moved from the ADR to delivery.md.
    • Round 2: a test that every packed target exists and that the peer is optional.
    • Round 3 was not empty, at the cap:
      • f26 and f28 were withdrawn after a mutation run by hand. lntt check tests mutate reported "no test runs this line" because it does not map package.json to the test that packs it.
      • f37 (a types condition per export) is fixed in 8c73a18, not reviewed again.
    • Left to the person: f23, a warning kept by the decisions lens. delivery.md:195, "every release is a patch (0.6.N)", writes the minor into the text, and the lens proposes 0.Y.N. That line predates this branch (00f946b). It is policy wording: if every release is a patch until 1.0.0, the minor stays 6.
    • Notes not done: the $schema convention named in agent-layer.md; the MIT license named in the ADR; the reason npm ignores publishConfig stated in both the ADR and delivery.md; null and wildcard export targets in the test helper; the ./ci import checks that the entry loads, not what it does; no recorded decision for the help spellings.

Closes #138

🤖 Generated with Claude Code

@lunette-candidates
lunette-candidates Bot changed the base branch from main to candidate/5 October 21, 2026 01:20
@lunette-candidates

Copy link
Copy Markdown

This pull request now targets candidate/5, the open candidate (#141): it reaches main with the candidate's merge, which also closes its issues.

A hotfix stays on main: add the hotfix label and move it back with gh pr edit 146 --base main (or name the branch hotfix/…). docs/process/delivery.md.

@ilmeskio
ilmeskio force-pushed the feat/138/publish-lntt-lntt-other branch from 248175b to 8c73a18 Compare October 21, 2026 01:22
…installs lntt

@lntt/lntt is no longer private: it carries the release version, so packages-version.mts
checks it and release.yml publishes it. The repo keeps running lntt from its sources
through the workspace link; the published manifest points bin and exports at dist/
through publishConfig, which pnpm applies when it packs, so the release packs each
package with pnpm and npm publishes the tarball. The build emits bin/ and src/ with
declarations and copies agents/ next to them; schema/ ships at the top level for a
project's $schema. @commitlint/config-conventional is a peer, the tool the package
configures. A test packs the package, installs it into a real node_modules and runs
the bin from there; lntt --help prints the usage and exits 0.

Closes #138
@commitlint/config-conventional is an optional peer: only commitlintConfig names it,
so lntt alone and npx @lntt/lntt --help install nothing more. -h and help are tested
with --help. The installed-bin test requires dist/agents and the operator schema in the
tarball, imports the ci entry and both schemas by name and compares their $id, shows a
failing build's output and cleans its temporary directories. The ADR states that a
pre-release publishes nothing and leaves the steps to the delivery process, which names
the publishConfig fields npm ignores.

Refs #138
…peer is optional

The installed-bin test walks every bin and exports target of the packed manifest,
types conditions included, and requires each one in the package; it requires the
commitlint peer to stay optional, and runs the three help spellings from node_modules.

Refs #138
@ilmeskio
ilmeskio force-pushed the feat/138/publish-lntt-lntt-other branch from 8c73a18 to ccb63ad Compare October 21, 2026 12:01
@ilmeskio
ilmeskio marked this pull request as ready for review October 21, 2026 12:01
@ilmeskio
ilmeskio merged commit 93d32cc into candidate/5 Oct 21, 2026
3 checks passed
@lunette-candidates lunette-candidates Bot mentioned this pull request Oct 21, 2026
ilmeskio added a commit that referenced this pull request Oct 21, 2026
@ilmeskio
ilmeskio deleted the feat/138/publish-lntt-lntt-other branch October 21, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish @lntt/lntt with the other @lntt packages, so a project installs the lntt command

1 participant