Skip to content

ci: run the scaffold tests on the full CI, and on a candidate pull request only when it touches packages/create - #151

Merged
ilmeskio merged 3 commits into
candidate/5from
ci/no-issue/scaffold-tests-full-ci
Oct 21, 2026
Merged

ilmeskio merged 3 commits into
candidate/5from
ci/no-issue/scaffold-tests-full-ci

Conversation

@ilmeskio

@ilmeskio ilmeskio commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What

The scaffold level of the tests (packages/create: a project generated and committed with git, @lntt/create packed with npm, and the smoke that installs, lints and typechecks a generated project) leaves the minimal CI, unless the change touches packages/create:

  • ci.yml: one test step, its condition written once. The full CI (base the default branch, or a push) runs pnpm test with SCAFFOLD_SMOKE=1, as before. A pull request into a candidate runs pnpm test when git diff origin/<base>...HEAD -- packages/create is not empty, pnpm test:minimal otherwise.
  • pnpm test:minimal (root package.json): every test but @lntt/create's.
  • scaffold.test.ts: the residue check (grep -rl) leaves out .git. A git process the scaffold leaves behind could still rewrite .git/objects while grep read it, and the test failed only under ci:local's load: reported in feat: queue ci:local runs on a lock and time out each step with the machine's load #150 as grep -rl __LNTT_ finding .git/objects/* entries vanishing while it reads, 1 run in 3 on candidate/5's own lntt ci local.
  • docs/process/ci.md states the rule and its reason, with the scaffold level on every candidate pull request among the discarded directions; the ci.yml header and the README say the same.

Why: the scaffold test is a smoke test, slow and machine-dependent; its red blocked every child of the lntt-v0-6-2 theme at once for reasons unrelated to their changes (the person's decision). A scaffold failure a pull request does not see is caught on the candidate and fixed forward there.

Definition of done

  • pnpm ci:local --base candidate/5 --list: the test step and its condition; on fd5e8e3 (no packages/create change in the comparison at the time) the minimal CI ran pnpm test:minimal in 40.4 s with no packages/create output; on c936402 (this branch touches packages/create) it ran @lntt/create's 9 tests, the smoke skipped
  • pnpm ci:local --base candidate/5 on b4d29d4: 1 passed, 0 failed
  • scaffold.test.ts alone: 3 runs in 3 green with the change
  • lntt review: 2 rounds (541k, 643k tokens). Round 1's blocker (the record said every test runs on every run) fixed by rewriting the rule in docs/process/ci.md; its warnings fixed (one step, one condition; headers and docs aligned). Round 2: f14 answered and withdrawn (the smoke was already full-CI only), f8 answered and withdrawn, notes fixed. f7 kept by its reviewer: no test fails if test:minimal stops excluding @lntt/create; the answer (a test of a script's text restates it, and the effect is only a slower minimal CI visible in the log) was not accepted. The person accepted the note as it is (2026-10-21): the risk is a slower minimal CI, never a defect that passes.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant